admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify RTPSender::RegisterRtpHeaderExtension

Browse Source 
DCHECK instead of run-time check extension type is correct.

BUG=webrtc:1994

Review-Url: https://codereview.webrtc.org/2795723002
Cr-Commit-Position: refs/heads/master@{#17524}
This commit is contained in:
danilchap 2017-04-04 02:33:48 -07:00 committed by Commit bot
parent 55a0135484
commit fab482b326
1 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
webrtc/modules/rtp_rtcp/source/rtp_sender.cc
View File

@ -186,20 +186,7 @@ uint32_t RTPSender::NackOverheadRate() const {
int32_t RTPSender::RegisterRtpHeaderExtension(RTPExtensionType type,
uint8_t id) {
rtc::CritScope lock(&send_critsect_);
switch (type) {
case kRtpExtensionVideoRotation:
case kRtpExtensionPlayoutDelay:
case kRtpExtensionTransmissionTimeOffset:
case kRtpExtensionAbsoluteSendTime:
case kRtpExtensionAudioLevel:
case kRtpExtensionTransportSequenceNumber:
return rtp_header_extension_map_.Register(type, id);
case kRtpExtensionNone:
case kRtpExtensionNumberOfExtensions:
LOG(LS_ERROR) << "Invalid RTP extension type for registration.";
return -1;
}
return -1;
return rtp_header_extension_map_.RegisterByType(id, type) ? 0 : -1;
}
bool RTPSender::IsRtpHeaderExtensionRegistered(RTPExtensionType type) const {