admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

generateKeyFrame: use GetParametersInternal

Browse Source 
since the externally visible GetParameters() method modifies
the last transaction id which is neither required nor desirable
for generateKeyFrame.

BUG=chromium:1354101

Change-Id: Iae9ea36f78258d3be6d02eb2858c8bf9c4c672c8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286740
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38911}
This commit is contained in:
Philipp Hancke 2022-12-07 08:59:24 +01:00 committed by WebRTC LUCI CQ
parent 794d599741
commit fa67bcc27a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pc/rtp_sender.cc
View File

@ -795,7 +795,7 @@ RTCError VideoRtpSender::GenerateKeyFrame(
const std::vector<std::string>& rids) { const std::vector<std::string>& rids) {
RTC_DCHECK_RUN_ON(signaling_thread_); RTC_DCHECK_RUN_ON(signaling_thread_);
if (video_media_channel() && ssrc_ && !stopped_) { if (video_media_channel() && ssrc_ && !stopped_) {
auto parameters = GetParameters(); const auto parameters = GetParametersInternal();
for (const auto& rid : rids) { for (const auto& rid : rids) {
if (rid.empty()) { if (rid.empty()) {
LOG_AND_RETURN_ERROR(RTCErrorType::INVALID_PARAMETER, LOG_AND_RETURN_ERROR(RTCErrorType::INVALID_PARAMETER,