From f9c295283746d6ff29dee9bea3d4d02ddee07e11 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Wed, 4 Jul 2018 11:47:33 +0200 Subject: [PATCH] Removing warning suppression flags in common_audio/. Bug: webrtc:9251 Change-Id: I9cae182ceb5e6bd3d6a34dc1a336ee3900f4cc98 Reviewed-on: https://webrtc-review.googlesource.com/86946 Reviewed-by: Karl Wiberg Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#23839} --- common_audio/BUILD.gn | 8 -------- common_audio/real_fourier.cc | 2 +- common_audio/signal_processing/complex_fft.c | 2 +- 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/common_audio/BUILD.gn b/common_audio/BUILD.gn index 63756a43f3..04f6e823d2 100644 --- a/common_audio/BUILD.gn +++ b/common_audio/BUILD.gn @@ -81,10 +81,6 @@ rtc_static_library("common_audio") { deps += [ ":common_audio_neon" ] } - if (is_win) { - cflags = [ "/wd4334" ] # Ignore warning on shift operator promotion. - } - public_configs = [ ":common_audio_config" ] if (!build_with_chromium && is_clang) { @@ -207,10 +203,6 @@ rtc_source_set("common_audio_c") { ] } - if (is_win) { - cflags = [ "/wd4334" ] # Ignore warning on shift operator promotion. - } - public_configs = [ ":common_audio_config" ] deps = [ ":common_audio_c_arm_asm", diff --git a/common_audio/real_fourier.cc b/common_audio/real_fourier.cc index f01c8eb2da..7365844e8d 100644 --- a/common_audio/real_fourier.cc +++ b/common_audio/real_fourier.cc @@ -31,7 +31,7 @@ int RealFourier::FftOrder(size_t length) { size_t RealFourier::FftLength(int order) { RTC_CHECK_GE(order, 0); - return static_cast(1 << order); + return size_t{1} << order; } size_t RealFourier::ComplexLength(int order) { diff --git a/common_audio/signal_processing/complex_fft.c b/common_audio/signal_processing/complex_fft.c index 36689b3c46..e2ac206925 100644 --- a/common_audio/signal_processing/complex_fft.c +++ b/common_audio/signal_processing/complex_fft.c @@ -166,7 +166,7 @@ int WebRtcSpl_ComplexIFFT(int16_t frfi[], int stages, int mode) /* The 1024-value is a constant given from the size of kSinTable1024[], * and should not be changed depending on the input parameter 'stages' */ - n = 1 << stages; + n = ((size_t)1) << stages; if (n > 1024) return -1;