From f90a3ad3b334dd164656bed05fd04f2b9b9a3937 Mon Sep 17 00:00:00 2001 From: Danil Chapovalov Date: Mon, 22 Jul 2024 15:52:45 +0200 Subject: [PATCH] Reenable disabled passing tests Libvpx was adjusted to support scenarios test verifies, but WebRTC tests were forgotten. Bug: webrtc:42223649 Change-Id: I19a10c939d844d00dd564bc0a16fe21844cc7cfb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/357680 Commit-Queue: Danil Chapovalov Reviewed-by: Philip Eliasson Cr-Commit-Position: refs/heads/main@{#42665} --- .../video_coding/codecs/vp9/test/vp9_impl_unittest.cc | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/modules/video_coding/codecs/vp9/test/vp9_impl_unittest.cc b/modules/video_coding/codecs/vp9/test/vp9_impl_unittest.cc index 9fd2875435..ae53001957 100644 --- a/modules/video_coding/codecs/vp9/test/vp9_impl_unittest.cc +++ b/modules/video_coding/codecs/vp9/test/vp9_impl_unittest.cc @@ -583,8 +583,8 @@ TEST(Vp9ImplTest, SpatialUpswitchNotAtGOFBoundary) { EXPECT_THAT(producer.SetNumInputFrames(1).Encode(), ElementsAre(GenericLayerIs(0, 0), GenericLayerIs(1, 0))); } -// TODO(bugs.webrtc.org/13442) Enable once a forward fix has landed in WebRTC. -TEST_F(TestVp9Impl, DISABLED_DisableEnableBaseLayerTriggersKeyFrame) { + +TEST_F(TestVp9Impl, DisableEnableBaseLayerTriggersKeyFrame) { // Configure encoder to produce N spatial layers. Encode frames for all // layers. Then disable all but the last layer. Then reenable all back again. test::ScopedFieldTrials override_field_trials( @@ -739,9 +739,8 @@ TEST_F(TestVp9Impl, DISABLED_DisableEnableBaseLayerTriggersKeyFrame) { EXPECT_EQ(encoded_frame[0]._frameType, expected_type); } } -// TODO(bugs.webrtc.org/13442) Enable once a forward fix has landed in WebRTC. -TEST(Vp9ImplTest, - DISABLED_DisableEnableBaseLayerWithSvcControllerTriggersKeyFrame) { + +TEST(Vp9ImplTest, DisableEnableBaseLayerWithSvcControllerTriggersKeyFrame) { // Configure encoder to produce N spatial layers. Encode frames for all // layers. Then disable all but the last layer. Then reenable all back again. const size_t num_spatial_layers = 3;