From f8f754a1a6d2aa437856edc7ae90d47c9b2b0ccd Mon Sep 17 00:00:00 2001 From: peah Date: Tue, 30 Aug 2016 10:31:45 -0700 Subject: [PATCH] Fixed the clang warning for ApmDataDumper BUG= Review-Url: https://codereview.webrtc.org/2296693002 Cr-Commit-Position: refs/heads/master@{#13975} --- .../audio_processing/logging/apm_data_dumper.cc | 9 +++++++++ .../audio_processing/logging/apm_data_dumper.h | 15 ++++++--------- 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/webrtc/modules/audio_processing/logging/apm_data_dumper.cc b/webrtc/modules/audio_processing/logging/apm_data_dumper.cc index 491196e097..3202006d3c 100644 --- a/webrtc/modules/audio_processing/logging/apm_data_dumper.cc +++ b/webrtc/modules/audio_processing/logging/apm_data_dumper.cc @@ -37,6 +37,15 @@ std::string FormFileName(const char* name, } // namespace +#if WEBRTC_AEC_DEBUG_DUMP == 1 +ApmDataDumper::ApmDataDumper(int instance_index) + : instance_index_(instance_index) {} +#else +ApmDataDumper::ApmDataDumper(int instance_index) {} +#endif + +ApmDataDumper::~ApmDataDumper() {} + #if WEBRTC_AEC_DEBUG_DUMP == 1 FILE* ApmDataDumper::GetRawFile(const char* name) { std::string filename = diff --git a/webrtc/modules/audio_processing/logging/apm_data_dumper.h b/webrtc/modules/audio_processing/logging/apm_data_dumper.h index eb3ee881a6..230c6b3a3e 100644 --- a/webrtc/modules/audio_processing/logging/apm_data_dumper.h +++ b/webrtc/modules/audio_processing/logging/apm_data_dumper.h @@ -40,15 +40,12 @@ struct RawFileCloseFunctor { // Class that handles dumping of variables into files. class ApmDataDumper { public: -// Constructor that takes an instance index that may -// be used to distinguish data dumped from different -// instances of the code. -#if WEBRTC_AEC_DEBUG_DUMP == 1 - explicit ApmDataDumper(int instance_index) - : instance_index_(instance_index) {} -#else - explicit ApmDataDumper(int instance_index) {} -#endif + // Constructor that takes an instance index that may + // be used to distinguish data dumped from different + // instances of the code. + explicit ApmDataDumper(int instance_index); + + ~ApmDataDumper(); // Reinitializes the data dumping such that new versions // of all files being dumped to are created.