admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Return correct type from OpenSSLStreamAdapter::VerifyPeerCertificate.

Browse Source 
The function signature expects to return a "bool" but in one code path it
returned "0".

BUG=None

Review-Url: https://codereview.webrtc.org/2742893002
Cr-Commit-Position: refs/heads/master@{#17156}
This commit is contained in:
jbauch 2017-03-09 16:24:57 -08:00 committed by Commit bot
parent 8f33fb3419
commit f8f457bd3f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
webrtc/base/opensslstreamadapter.cc
View File

@ -1090,7 +1090,7 @@ bool OpenSSLStreamAdapter::VerifyPeerCertificate() {
Buffer computed_digest(digest, digest_length); Buffer computed_digest(digest, digest_length);
if (computed_digest != peer_certificate_digest_value_) { if (computed_digest != peer_certificate_digest_value_) {
LOG(LS_WARNING) << "Rejected peer certificate due to mismatched digest."; LOG(LS_WARNING) << "Rejected peer certificate due to mismatched digest.";
return 0; return false;
} }
// Ignore any verification error if the digest matches, since there is no // Ignore any verification error if the digest matches, since there is no
// value in checking the validity of a self-signed cert issued by untrusted // value in checking the validity of a self-signed cert issued by untrusted