From f8f457bd3f5bfc4907cd593a05ae7d72b9863d5c Mon Sep 17 00:00:00 2001 From: jbauch Date: Thu, 9 Mar 2017 16:24:57 -0800 Subject: [PATCH] Return correct type from OpenSSLStreamAdapter::VerifyPeerCertificate. The function signature expects to return a "bool" but in one code path it returned "0". BUG=None Review-Url: https://codereview.webrtc.org/2742893002 Cr-Commit-Position: refs/heads/master@{#17156} --- webrtc/base/opensslstreamadapter.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webrtc/base/opensslstreamadapter.cc b/webrtc/base/opensslstreamadapter.cc index afcf39ffe1..d1c16a126e 100644 --- a/webrtc/base/opensslstreamadapter.cc +++ b/webrtc/base/opensslstreamadapter.cc @@ -1090,7 +1090,7 @@ bool OpenSSLStreamAdapter::VerifyPeerCertificate() { Buffer computed_digest(digest, digest_length); if (computed_digest != peer_certificate_digest_value_) { LOG(LS_WARNING) << "Rejected peer certificate due to mismatched digest."; - return 0; + return false; } // Ignore any verification error if the digest matches, since there is no // value in checking the validity of a self-signed cert issued by untrusted