admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable failing fullstack test with 15 thumbnail streams

Browse Source 
BUG=webrtc:7301

Review-Url: https://codereview.webrtc.org/2739613003
Cr-Commit-Position: refs/heads/master@{#17095}
This commit is contained in:
ilnik 2017-03-07 06:15:27 -08:00 committed by Commit bot
parent bddab23c88
commit f89a738626
2 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
webrtc/video/full_stack_tests.cc
View File

@ -507,7 +507,15 @@ TEST_F(FullStackTest, LargeRoomVP8_5thumb) {
RunTest(large_room);
}
TEST_F(FullStackTest, LargeRoomVP8_15thumb) {
#if defined(WEBRTC_ANDROID) || defined(WEBRTC_WIN)
// Fails on Android and win:
// https://bugs.chromium.org/p/webrtc/issues/detail?id=7301
#define MAYBE_LargeRoomVP8_50thumb DISABLED_LargeRoomVP8_50thumb
#else
#define MAYBE_LargeRoomVP8_50thumb LargeRoomVP8_50thumb
#endif
TEST_F(FullStackTest, MAYBE_LargeRoomVP8_15thumb) {
VideoQualityTest::Params large_room;
large_room.call.send_side_bwe = true;
large_room.video = kSimulcastVp8VideoHigh;
@ -530,14 +538,6 @@ TEST_F(FullStackTest, LargeRoomVP8_15thumb) {
RunTest(large_room);
}
#if defined(WEBRTC_ANDROID) || defined(WEBRTC_WIN)
// Fails on Android and win:
// https://bugs.chromium.org/p/webrtc/issues/detail?id=7301
#define MAYBE_LargeRoomVP8_50thumb DISABLED_LargeRoomVP8_50thumb
#else
#define MAYBE_LargeRoomVP8_50thumb LargeRoomVP8_50thumb
#endif
TEST_F(FullStackTest, MAYBE_LargeRoomVP8_50thumb) {
VideoQualityTest::Params large_room;
large_room.call.send_side_bwe = true;

1
webrtc/video/video_quality_test.cc
View File

@ -1515,6 +1515,7 @@ void VideoQualityTest::SetupThumbnailCapturers(size_t num_thumbnail_streams) {
thumbnail_capturers_.emplace_back(test::FrameGeneratorCapturer::Create(
static_cast<int>(thumbnail.width), static_cast<int>(thumbnail.height),
thumbnail.max_framerate, clock_));
RTC_DCHECK(thumbnail_capturers_.back());
}
}