admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Changing the pre echo configuration default.

Browse Source 
Bug: webrtc:14205
Change-Id: I17add3bf19c599f170ffe98d0da0a561794591c1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/309481
Commit-Queue: Jesus de Vicente Pena <devicentepena@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40319}
This commit is contained in:
Jesús de Vicente Peña 2023-06-20 15:14:30 +02:00 committed by WebRTC LUCI CQ
parent ff58aed678
commit f80cf81435
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
modules/audio_processing/aec3/matched_filter.cc
View File

@ -109,14 +109,16 @@ size_t ComputePreEchoLag(
}
webrtc::MatchedFilter::PreEchoConfiguration FetchPreEchoConfiguration() {
float threshold = 0.5f;
int mode = 0;
constexpr float kDefaultThreshold = 0.5f;
constexpr int kDefaultMode = 3;
float threshold = kDefaultThreshold;
int mode = kDefaultMode;
const std::string pre_echo_configuration_field_trial =
webrtc::field_trial::FindFullName("WebRTC-Aec3PreEchoConfiguration");
webrtc::FieldTrialParameter<double> threshold_field_trial_parameter(
/*key=*/"threshold", /*default_value=*/threshold);
/*key=*/"threshold", /*default_value=*/kDefaultThreshold);
webrtc::FieldTrialParameter<int> mode_field_trial_parameter(
/*key=*/"mode", /*default_value=*/mode);
/*key=*/"mode", /*default_value=*/kDefaultMode);
webrtc::ParseFieldTrial(
{&threshold_field_trial_parameter, &mode_field_trial_parameter},
pre_echo_configuration_field_trial);

2
modules/audio_processing/aec3/matched_filter_unittest.cc
View File

@ -584,7 +584,7 @@ TEST(MatchedFilterFieldTrialTest, PreEchoConfigurationTest) {
TEST(MatchedFilterFieldTrialTest, WrongPreEchoConfigurationTest) {
constexpr float kDefaultThreshold = 0.5f;
constexpr int kDefaultMode = 0;
constexpr int kDefaultMode = 3;
float threshold_in = -0.1f;
int mode_in = 5;
rtc::StringBuilder field_trial_name;