From f7d7e90c5ef41c3a0433104eaffef374368b9e96 Mon Sep 17 00:00:00 2001 From: Artem Titov Date: Wed, 13 Jun 2018 22:52:46 +0200 Subject: [PATCH] Replace std:remove on vector::erase in streamparams_unittest.cc Replace std:remove on vector::erase to actually remove object from the vector. Change-Id: I1eae7a038769ca4eb45a2f9238ca7aa86b3c38a4 Bug: webrtc:9405 Reviewed-on: https://webrtc-review.googlesource.com/83342 Commit-Queue: Artem Titov Reviewed-by: Taylor Brandstetter Cr-Commit-Position: refs/heads/master@{#23604} --- media/base/streamparams_unittest.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/media/base/streamparams_unittest.cc b/media/base/streamparams_unittest.cc index 020953b4cf..87ce5d9bd8 100644 --- a/media/base/streamparams_unittest.cc +++ b/media/base/streamparams_unittest.cc @@ -308,7 +308,9 @@ TEST(StreamParams, TestIsSimulcastStream_InvalidStreams) { cricket::StreamParams stream2; stream2.add_ssrc(13); EXPECT_TRUE(stream2.AddFidSsrc(13, 14)); - std::remove(stream2.ssrcs.begin(), stream2.ssrcs.end(), 13u); + stream2.ssrcs.erase( + std::remove(stream2.ssrcs.begin(), stream2.ssrcs.end(), 13u), + stream2.ssrcs.end()); EXPECT_FALSE(cricket::IsSimulcastStream(stream2)); // stream3 has two SIM groups.