From f7b9cf54a6b6085b67696d8d9c3c53b0b67758f5 Mon Sep 17 00:00:00 2001 From: Minyue Li Date: Mon, 30 Mar 2015 17:26:34 +0200 Subject: [PATCH] Suppress "EndToEndTest::ReceivedFecPacketsNotNacked" on Asan, Tsan BUG=4328 R=kjellander@webrtc.org, pbos@webrtc.org Review URL: https://webrtc-codereview.appspot.com/47859004 Cr-Commit-Position: refs/heads/master@{#8892} --- webrtc/video/end_to_end_tests.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc index b7f0603062..8fdde56870 100644 --- a/webrtc/video/end_to_end_tests.cc +++ b/webrtc/video/end_to_end_tests.cc @@ -543,7 +543,13 @@ TEST_F(EndToEndTest, CanReceiveFec) { RunBaseTest(&test); } -TEST_F(EndToEndTest, ReceivedFecPacketsNotNacked) { +// Flacky on ASan and TSan. See webrtc:4328. +#if defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER) +#define MAYBE_ReceivedFecPacketsNotNacked DISABLED_ReceivedFecPacketsNotNacked +#else +#define MAYBE_ReceivedFecPacketsNotNacked ReceivedFecPacketsNotNacked +#endif +TEST_F(EndToEndTest, MAYBE_ReceivedFecPacketsNotNacked) { // At low RTT (< kLowRttNackMs) -> NACK only, no FEC. // Configure some network delay. const int kNetworkDelayMs = 50;