From f75daa8cb95ed811eb09dc8ed99ddc34605b1d93 Mon Sep 17 00:00:00 2001 From: Zijie He Date: Tue, 5 Sep 2017 15:15:59 -0700 Subject: [PATCH] Add a comment to explain the coordinate of GetWindowRectInVirtualScreen() CroppingWindowCapturer::GetWindowRectInVirtualScreen() expects to return a rectangle in full desktop coordinate. Bug: webrtc:7950 Change-Id: Id1b5de4d655cfc3f375434a696c77029c684880b Reviewed-on: https://chromium-review.googlesource.com/651706 Reviewed-by: Jamie Walch Commit-Queue: Zijie He Cr-Commit-Position: refs/heads/master@{#19700} --- webrtc/modules/desktop_capture/cropping_window_capturer.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/webrtc/modules/desktop_capture/cropping_window_capturer.h b/webrtc/modules/desktop_capture/cropping_window_capturer.h index 5b5a41d482..b8b2751d02 100644 --- a/webrtc/modules/desktop_capture/cropping_window_capturer.h +++ b/webrtc/modules/desktop_capture/cropping_window_capturer.h @@ -55,7 +55,9 @@ class CroppingWindowCapturer : public DesktopCapturer, virtual bool ShouldUseScreenCapturer() = 0; // Returns the window area relative to the top left of the virtual screen - // within the bounds of the virtual screen. + // within the bounds of the virtual screen. This function should return the + // DesktopRect in full desktop coordinates, i.e. the top-left monitor starts + // from (0, 0). virtual DesktopRect GetWindowRectInVirtualScreen() = 0; WindowId selected_window() const { return selected_window_; }