From f6eb9d64b281d2e689988001435864620197cd2e Mon Sep 17 00:00:00 2001 From: Wan-Teh Chang Date: Tue, 14 Feb 2023 14:28:47 -0800 Subject: [PATCH] Declare kMinimumFrameRate for AV1 codec as double MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The kMinimumFrameRate constant is only used in a comparison with RateControlParameters::framerate_fps, which is of the double type. Declare kMinimumFrameRate as double to match. Note: The kMinimumFrameRate constant was added in https://webrtc-review.googlesource.com/c/src/+/170360. Bug: webrtc:11404 Change-Id: I11769867d4e52a720219c8a0ade8e8b74d13ca86 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/293384 Reviewed-by: Danil Chapovalov Reviewed-by: Erik Språng Commit-Queue: Wan-Teh Chang Cr-Commit-Position: refs/heads/main@{#39320} --- modules/video_coding/codecs/av1/libaom_av1_encoder.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/video_coding/codecs/av1/libaom_av1_encoder.cc b/modules/video_coding/codecs/av1/libaom_av1_encoder.cc index 747017612b..e89dc29ed4 100644 --- a/modules/video_coding/codecs/av1/libaom_av1_encoder.cc +++ b/modules/video_coding/codecs/av1/libaom_av1_encoder.cc @@ -56,7 +56,7 @@ constexpr int kMaxQindex = 205; // Max qindex threshold for QP scaling. constexpr int kBitDepth = 8; constexpr int kLagInFrames = 0; // No look ahead. constexpr int kRtpTicksPerSecond = 90000; -constexpr float kMinimumFrameRate = 1.0; +constexpr double kMinimumFrameRate = 1.0; aom_superblock_size_t GetSuperblockSize(int width, int height, int threads) { int resolution = width * height;