admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete unused rtp_rtcp method "SetCsrcs"

Browse Source 
The CSRC concept is really a frame level concept.
Setting it per sender is a quick hack, and should be minimized.
This function doesn't seem to be used anywhere, so removing it
lessens the chance of confusion.

Bug: webrtc:7135
Change-Id: Ia3c27b5984b153e68bc51d93b03f08f7f867adc0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286426
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Tony Herre <herre@google.com>
Cr-Commit-Position: refs/heads/main@{#38822}
This commit is contained in:
Harald Alvestrand 2022-12-06 10:08:21 +00:00 committed by WebRTC LUCI CQ
parent 279b4b7d4f
commit f6777a4997
6 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
modules/rtp_rtcp/mocks/mock_rtp_rtcp.h
View File

@ -67,7 +67,6 @@ class MockRtpRtcpInterface : public RtpRtcpInterface {
MOCK_METHOD(RtpState, GetRtxState, (), (const, override));
MOCK_METHOD(uint32_t, SSRC, (), (const, override));
MOCK_METHOD(void, SetMid, (absl::string_view mid), (override));
MOCK_METHOD(void, SetCsrcs, (const std::vector<uint32_t>& csrcs), (override));
MOCK_METHOD(void, SetRtxSendStatus, (int modes), (override));
MOCK_METHOD(int, RtxSendStatus, (), (const, override));
MOCK_METHOD(absl::optional<uint32_t>, RtxSsrc, (), (const, override));

5
modules/rtp_rtcp/source/rtp_rtcp_impl.cc
View File

@ -265,11 +265,6 @@ void ModuleRtpRtcpImpl::SetMid(absl::string_view mid) {
// RTCP, this will need to be passed down to the RTCPSender also.
}
void ModuleRtpRtcpImpl::SetCsrcs(const std::vector<uint32_t>& csrcs) {
rtcp_sender_.SetCsrcs(csrcs);
rtp_sender_->packet_generator.SetCsrcs(csrcs);
}
// TODO(pbos): Handle media and RTX streams separately (separate RTCP
// feedbacks).
RTCPSender::FeedbackState ModuleRtpRtcpImpl::GetFeedbackState() {

2
modules/rtp_rtcp/source/rtp_rtcp_impl.h
View File

@ -103,8 +103,6 @@ class ABSL_DEPRECATED("") ModuleRtpRtcpImpl
void SetMid(absl::string_view mid) override;
void SetCsrcs(const std::vector<uint32_t>& csrcs) override;
RTCPSender::FeedbackState GetFeedbackState();
void SetRtxSendStatus(int mode) override;

5
modules/rtp_rtcp/source/rtp_rtcp_impl2.cc
View File

@ -230,11 +230,6 @@ void ModuleRtpRtcpImpl2::SetMid(absl::string_view mid) {
// RTCP, this will need to be passed down to the RTCPSender also.
}
void ModuleRtpRtcpImpl2::SetCsrcs(const std::vector<uint32_t>& csrcs) {
rtcp_sender_.SetCsrcs(csrcs);
rtp_sender_->packet_generator.SetCsrcs(csrcs);
}
// TODO(pbos): Handle media and RTX streams separately (separate RTCP
// feedbacks).
RTCPSender::FeedbackState ModuleRtpRtcpImpl2::GetFeedbackState() {

2
modules/rtp_rtcp/source/rtp_rtcp_impl2.h
View File

@ -114,8 +114,6 @@ class ModuleRtpRtcpImpl2 final : public RtpRtcpInterface,
void SetMid(absl::string_view mid) override;
void SetCsrcs(const std::vector<uint32_t>& csrcs) override;
RTCPSender::FeedbackState GetFeedbackState();
void SetRtxSendStatus(int mode) override;

4
modules/rtp_rtcp/source/rtp_rtcp_interface.h
View File

@ -258,10 +258,6 @@ class RtpRtcpInterface : public RtcpFeedbackSenderInterface {
// Once set, this value can not be changed or removed.
virtual void SetMid(absl::string_view mid) = 0;
// Sets CSRC.
// `csrcs` - vector of CSRCs
virtual void SetCsrcs(const std::vector<uint32_t>& csrcs) = 0;
// Turns on/off sending RTX (RFC 4588). The modes can be set as a combination
// of values of the enumerator RtxMode.
virtual void SetRtxSendStatus(int modes) = 0;