From f666ecc60d48a3c037b77a0c6e6d40b46567aa76 Mon Sep 17 00:00:00 2001 From: "phoglund@webrtc.org" Date: Tue, 27 May 2014 08:08:00 +0000 Subject: [PATCH] Disabling flaky libjingle tests after fixit week. BUG=webrtc:3316,webrtc:3317,webrtc:3318 TBR=fischman@google.com Review URL: https://webrtc-codereview.appspot.com/12569004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6250 4adac7df-926f-26a2-2b94-8c16560cd09d --- talk/base/sharedexclusivelock_unittest.cc | 3 ++- talk/p2p/base/p2ptransportchannel_unittest.cc | 3 ++- talk/p2p/base/port_unittest.cc | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/talk/base/sharedexclusivelock_unittest.cc b/talk/base/sharedexclusivelock_unittest.cc index 46b7fdfdc2..e280aa28a8 100644 --- a/talk/base/sharedexclusivelock_unittest.cc +++ b/talk/base/sharedexclusivelock_unittest.cc @@ -148,7 +148,8 @@ class SharedExclusiveLockTest int value_; }; -TEST_F(SharedExclusiveLockTest, TestSharedShared) { +// Flaky: https://code.google.com/p/webrtc/issues/detail?id=3318 +TEST_F(SharedExclusiveLockTest, DISABLED_TestSharedShared) { int value0, value1; bool done0, done1; ReadTask reader0(shared_exclusive_lock_.get(), &value_, &done0); diff --git a/talk/p2p/base/p2ptransportchannel_unittest.cc b/talk/p2p/base/p2ptransportchannel_unittest.cc index fe22cb3e16..498fde9dca 100644 --- a/talk/p2p/base/p2ptransportchannel_unittest.cc +++ b/talk/p2p/base/p2ptransportchannel_unittest.cc @@ -1530,7 +1530,8 @@ TEST_F(P2PTransportChannelTest, TestDefaultDscpValue) { } // Verify IPv6 connection is preferred over IPv4. -TEST_F(P2PTransportChannelTest, TestIPv6Connections) { +// Flaky: https://code.google.com/p/webrtc/issues/detail?id=3317 +TEST_F(P2PTransportChannelTest, DISABLED_TestIPv6Connections) { AddAddress(0, kIPv6PublicAddrs[0]); AddAddress(0, kPublicAddrs[0]); AddAddress(1, kIPv6PublicAddrs[1]); diff --git a/talk/p2p/base/port_unittest.cc b/talk/p2p/base/port_unittest.cc index 804b61ec34..fc6d48c9a5 100644 --- a/talk/p2p/base/port_unittest.cc +++ b/talk/p2p/base/port_unittest.cc @@ -895,7 +895,8 @@ TEST_F(PortTest, TestLocalToSymNat) { TestLocalToStun(NAT_SYMMETRIC); } -TEST_F(PortTest, TestLocalToTurn) { +// Flaky: https://code.google.com/p/webrtc/issues/detail?id=3316. +TEST_F(PortTest, DISABLED_TestLocalToTurn) { TestLocalToRelay(RELAY_TURN, PROTO_UDP); }