From f653f476f066f2a0f6befe62c2ebab55d207dab4 Mon Sep 17 00:00:00 2001 From: Dor Hen Date: Wed, 2 Oct 2024 11:45:02 -0700 Subject: [PATCH] Remove unused parameters from "WebRtcSpl_FilterAR" Bug: webrtc:370878648 Change-Id: Ia7c9046a7c0f415e1f28df9610f818af402e055f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/364503 Reviewed-by: Harald Alvestrand Reviewed-by: Henrik Lundin Commit-Queue: Danil Chapovalov Cr-Commit-Position: refs/heads/main@{#43158} --- common_audio/signal_processing/filter_ar.c | 4 +--- .../signal_processing/include/signal_processing_library.h | 7 +------ .../signal_processing/signal_processing_unittest.cc | 6 +++--- modules/audio_coding/codecs/cng/webrtc_cng.cc | 3 +-- 4 files changed, 6 insertions(+), 14 deletions(-) diff --git a/common_audio/signal_processing/filter_ar.c b/common_audio/signal_processing/filter_ar.c index b1f666d723..b76e3881e2 100644 --- a/common_audio/signal_processing/filter_ar.c +++ b/common_audio/signal_processing/filter_ar.c @@ -26,10 +26,8 @@ size_t WebRtcSpl_FilterAR(const int16_t* a, int16_t* state, size_t state_length, int16_t* state_low, - size_t state_low_length, int16_t* filtered, - int16_t* filtered_low, - size_t filtered_low_length) + int16_t* filtered_low) { int64_t o; int32_t oLOW; diff --git a/common_audio/signal_processing/include/signal_processing_library.h b/common_audio/signal_processing/include/signal_processing_library.h index 48c9b309b4..ac0d277785 100644 --- a/common_audio/signal_processing/include/signal_processing_library.h +++ b/common_audio/signal_processing/include/signal_processing_library.h @@ -621,10 +621,8 @@ size_t WebRtcSpl_FilterAR(const int16_t* ar_coef, int16_t* filter_state, size_t filter_state_length, int16_t* filter_state_low, - size_t filter_state_low_length, int16_t* out_vector, - int16_t* out_vector_low, - size_t out_vector_low_length); + int16_t* out_vector_low); // WebRtcSpl_FilterMAFastQ12(...) // @@ -1464,9 +1462,6 @@ void WebRtcSpl_SynthesisQMF(const int16_t* low_band, // - filter_state : Current state (higher part) of the filter. // - filter_state_length : Length (in samples) of `filter_state`. // - filter_state_low : Current state (lower part) of the filter. -// - filter_state_low_length : Length (in samples) of `filter_state_low`. -// - out_vector_low_length : Maximum length (in samples) of -// `out_vector_low`. // // Output: // - filter_state : Updated state (upper part) vector. diff --git a/common_audio/signal_processing/signal_processing_unittest.cc b/common_audio/signal_processing/signal_processing_unittest.cc index 2a8e9bd5c3..855b9808d1 100644 --- a/common_audio/signal_processing/signal_processing_unittest.cc +++ b/common_audio/signal_processing/signal_processing_unittest.cc @@ -499,9 +499,9 @@ TEST(SplTest, FilterTest) { kFilterOrder + 1, 1); EXPECT_EQ(0, data_out[kFilterOrder]); - EXPECT_EQ(kVectorSize, WebRtcSpl_FilterAR(A5, 5, data_in, kVectorSize, bState, - kVectorSize, bStateLow, kVectorSize, - data_out, bTmp16Low, kVectorSize)); + EXPECT_EQ(kVectorSize, + WebRtcSpl_FilterAR(A5, 5, data_in, kVectorSize, bState, kVectorSize, + bStateLow, data_out, bTmp16Low)); } TEST(SplTest, RandTest) { diff --git a/modules/audio_coding/codecs/cng/webrtc_cng.cc b/modules/audio_coding/codecs/cng/webrtc_cng.cc index 48f1b8c296..20b2603b02 100644 --- a/modules/audio_coding/codecs/cng/webrtc_cng.cc +++ b/modules/audio_coding/codecs/cng/webrtc_cng.cc @@ -199,8 +199,7 @@ bool ComfortNoiseDecoder::Generate(rtc::ArrayView out_data, * `out_data` - Filtered speech samples. */ WebRtcSpl_FilterAR(lpPoly, WEBRTC_CNG_MAX_LPC_ORDER + 1, excitation, num_samples, dec_filtstate_, WEBRTC_CNG_MAX_LPC_ORDER, - dec_filtstateLow_, WEBRTC_CNG_MAX_LPC_ORDER, - out_data.data(), low, num_samples); + dec_filtstateLow_, out_data.data(), low); return true; }