From f591f2dcf1bfb00f25967d214776fee6b675e2ef Mon Sep 17 00:00:00 2001 From: Emil Lundmark Date: Tue, 2 Apr 2024 16:20:26 +0200 Subject: [PATCH] Remove expired WebRTC-Aec3DelayEstimatorDetectPreEcho MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:14205 Change-Id: Ib817b043d9368ba003b2b40a7315da845910c2f2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/345481 Reviewed-by: Lionel Koenig Gélas Commit-Queue: Emil Lundmark Reviewed-by: Lionel Koenig Cr-Commit-Position: refs/heads/main@{#42039} --- experiments/field_trials.py | 3 --- modules/audio_processing/aec3/echo_canceller3.cc | 8 -------- 2 files changed, 11 deletions(-) diff --git a/experiments/field_trials.py b/experiments/field_trials.py index 3e65411bc8..0bef7ef896 100755 --- a/experiments/field_trials.py +++ b/experiments/field_trials.py @@ -42,9 +42,6 @@ class FieldTrial: # registered in the container below. ACTIVE_FIELD_TRIALS: FrozenSet[FieldTrial] = frozenset([ # keep-sorted start - FieldTrial('WebRTC-Aec3DelayEstimatorDetectPreEcho', - 'webrtc:14205', - date(2024, 4, 1)), FieldTrial('WebRTC-Audio-GainController2', 'webrtc:7494', date(2024, 4, 1)), diff --git a/modules/audio_processing/aec3/echo_canceller3.cc b/modules/audio_processing/aec3/echo_canceller3.cc index e8e2175994..fcd9757ad1 100644 --- a/modules/audio_processing/aec3/echo_canceller3.cc +++ b/modules/audio_processing/aec3/echo_canceller3.cc @@ -378,14 +378,6 @@ EchoCanceller3Config AdjustConfig(const EchoCanceller3Config& config) { false; } - if (field_trial::IsEnabled("WebRTC-Aec3DelayEstimatorDetectPreEcho")) { - adjusted_cfg.delay.detect_pre_echo = true; - } - - if (field_trial::IsDisabled("WebRTC-Aec3DelayEstimatorDetectPreEcho")) { - adjusted_cfg.delay.detect_pre_echo = false; - } - if (field_trial::IsEnabled("WebRTC-Aec3SensitiveDominantNearendActivation")) { adjusted_cfg.suppressor.dominant_nearend_detection.enr_threshold = 0.5f; } else if (field_trial::IsEnabled(