From f4ee036871f26e350a4f6e242a52fd802c74236d Mon Sep 17 00:00:00 2001 From: Marina Ciocea Date: Wed, 22 Apr 2020 11:57:17 +0200 Subject: [PATCH] [InsertableStreams] Clear callback to audio receive channel in delegate. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reset the frame transformer delegate's callback to ChannelReceive::OnReceivedPayloadData when the channel is destroyed, to prevent future callbacks from the delegate. Bug: chromium:870644 Change-Id: Iaa2c1b7b26dc38709d3fe64a180ccc6a60a1ec9c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173751 Reviewed-by: Per Åhgren Commit-Queue: Marina Ciocea Cr-Commit-Position: refs/heads/master@{#31121} --- audio/channel_receive.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/audio/channel_receive.cc b/audio/channel_receive.cc index ebc6a2abbe..66b4bb11f5 100644 --- a/audio/channel_receive.cc +++ b/audio/channel_receive.cc @@ -520,6 +520,10 @@ ChannelReceive::ChannelReceive( ChannelReceive::~ChannelReceive() { RTC_DCHECK(construction_thread_.IsCurrent()); + // Resets the delegate's callback to ChannelReceive::OnReceivedPayloadData. + if (frame_transformer_delegate_) + frame_transformer_delegate_->Reset(); + StopPlayout(); if (_moduleProcessThreadPtr)