From f4c01623108dea94886d21329236e83d6807807d Mon Sep 17 00:00:00 2001 From: Sameer Vijaykar Date: Thu, 11 Aug 2022 17:38:51 +0200 Subject: [PATCH] Cleanup: Make AsyncResolveInterface::Start(addr,family) pure virtual Dependencies have been updated now. Bug: webrtc:14319, webrtc:14131 Change-Id: I03397f6dfa17cbb2faa85346c5ea37847f1e2482 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271344 Reviewed-by: Mirko Bonadei Commit-Queue: Sameer Vijaykar Cr-Commit-Position: refs/heads/main@{#37944} --- rtc_base/async_resolver_interface.h | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/rtc_base/async_resolver_interface.h b/rtc_base/async_resolver_interface.h index 998ebd800d..829dc7e23b 100644 --- a/rtc_base/async_resolver_interface.h +++ b/rtc_base/async_resolver_interface.h @@ -27,11 +27,7 @@ class RTC_EXPORT AsyncResolverInterface { // Start address resolution of the hostname in `addr`. virtual void Start(const SocketAddress& addr) = 0; // Start address resolution of the hostname in `addr` matching `family`. - virtual void Start(const SocketAddress& addr, int family) { - // TODO(webrtc:14319) make pure virtual when all subclasses have been - // updated. - RTC_DCHECK_NOTREACHED(); - } + virtual void Start(const SocketAddress& addr, int family) = 0; // Returns true iff the address from `Start` was successfully resolved. // If the address was successfully resolved, sets `addr` to a copy of the // address from `Start` with the IP address set to the top most resolved