From f3d622d4ade9364259d8028aee39c68f41c86918 Mon Sep 17 00:00:00 2001 From: aleloi Date: Thu, 26 Jan 2017 01:50:46 -0800 Subject: [PATCH] Revert of Disabled two iOS tests due to bot breakage. Affected tests are (patchset #1 id:1 of https://codereview.webrtc.org/2652423002/ ) Reason for revert: This was false alarm. The next Chromium roll fixed the problem and the bot has been green for 3 builds. Original issue's description: > Disabled two iOS tests due to bot breakage. Affected tests are > AudioDeviceTest.RunPlayoutWithFileAsSource and > AudioDeviceTest.StartStopRecording > > NOTRY=True > TBR=henrika@webrtc.org > BUG=7056 > > Review-Url: https://codereview.webrtc.org/2652423002 > Cr-Commit-Position: refs/heads/master@{#16286} > Committed: https://chromium.googlesource.com/external/webrtc/+/8e775e16eba1c3d2983f24d3fcf59400f79b9783 TBR=henrika@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=7056 Review-Url: https://codereview.webrtc.org/2656533005 Cr-Commit-Position: refs/heads/master@{#16289} --- .../modules/audio_device/ios/audio_device_unittest_ios.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc b/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc index dd284c12f8..1b7ff5780f 100644 --- a/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc +++ b/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc @@ -598,8 +598,7 @@ TEST_F(AudioDeviceTest, DISABLED_StartStopPlayout) { // Tests that recording can be initiated, started and stopped. No audio callback // is registered in this test. -// Disabled due to failure: bugs.webrtc.org/7056 -TEST_F(AudioDeviceTest, DISABLED_StartStopRecording) { +TEST_F(AudioDeviceTest, StartStopRecording) { StartRecording(); StopRecording(); StartRecording(); @@ -734,8 +733,7 @@ TEST_F(AudioDeviceTest, StartPlayoutAndRecordingVerifyCallbacks) { // Start playout and read audio from an external PCM file when the audio layer // asks for data to play out. Real audio is played out in this test but it does // not contain any explicit verification that the audio quality is perfect. -// Disabled due to failure: bugs.webrtc.org/7056 -TEST_F(AudioDeviceTest, DISABLED_RunPlayoutWithFileAsSource) { +TEST_F(AudioDeviceTest, RunPlayoutWithFileAsSource) { // TODO(henrika): extend test when mono output is supported. EXPECT_EQ(1, playout_channels()); NiceMock mock(kPlayout);