From f3a7c9d732bcb4ed59323d78f5e521615a46fdc2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20Spr=C3=A5ng?= Date: Mon, 5 Oct 2015 14:03:22 +0200 Subject: [PATCH] In rampup tests, set start time when starting poller thread. This should avoid perf change caused by https://codereview.webrtc.org/1378303004 BUG=539257 R=stefan@webrtc.org Review URL: https://codereview.webrtc.org/1383223002 . Cr-Commit-Position: refs/heads/master@{#10168} --- webrtc/video/rampup_tests.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/webrtc/video/rampup_tests.cc b/webrtc/video/rampup_tests.cc index 526f4a4f76..6459c3b30e 100644 --- a/webrtc/video/rampup_tests.cc +++ b/webrtc/video/rampup_tests.cc @@ -55,7 +55,7 @@ RampUpTester::RampUpTester(size_t num_streams, start_bitrate_bps_(start_bitrate_bps), start_bitrate_verified_(false), expected_bitrate_bps_(0), - test_start_ms_(clock_->TimeInMilliseconds()), + test_start_ms_(-1), ramp_up_finished_ms_(-1), extension_type_(extension_type), ssrcs_(GenerateSsrcs(num_streams, 100)), @@ -226,6 +226,8 @@ void RampUpTester::AccumulateStats(const VideoSendStream::StreamStats& stream, } void RampUpTester::TriggerTestDone() { + RTC_DCHECK_GE(test_start_ms_, 0); + VideoSendStream::Stats send_stats = send_stream_->GetStats(); size_t total_packets_sent = 0; @@ -262,6 +264,7 @@ void RampUpTester::TriggerTestDone() { } void RampUpTester::PerformTest() { + test_start_ms_ = clock_->TimeInMilliseconds(); poller_thread_->Start(); if (Wait() != kEventSignaled) { printf("Timed out while waiting for ramp-up to complete.");