admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use ElementsAreArray in corruption detection unittests

Browse Source 
Remove incorrect parantheses around expression as well

Bug: webrtc:358039777
Change-Id: I0e5de93b3ef23a18989e50fbe70a37c6ed198290
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/375240
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Fanny Linderborg <linderborg@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43796}
This commit is contained in:
Fanny Linderborg 2025-01-24 12:40:28 +01:00 committed by WebRTC LUCI CQ
parent 1cc5e54368
commit f2ecdd7ea3
1 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
modules/rtp_rtcp/source/corruption_detection_extension_unittest.cc
View File

@ -23,6 +23,7 @@ namespace {
using ::testing::DoubleEq; using ::testing::DoubleEq;
using ::testing::ElementsAre; using ::testing::ElementsAre;
using ::testing::ElementsAreArray;
TEST(CorruptionDetectionExtensionTest, ValueSizeIs1UnlessSamplesAreSpecified) { TEST(CorruptionDetectionExtensionTest, ValueSizeIs1UnlessSamplesAreSpecified) {
const std::optional<CorruptionDetectionMessage> kMessage = const std::optional<CorruptionDetectionMessage> kMessage =
@ -117,7 +118,7 @@ TEST(CorruptionDetectionExtensionTest,
CorruptionDetectionMessage::Builder() CorruptionDetectionMessage::Builder()
.WithSequenceIndex(0b0110'1111) .WithSequenceIndex(0b0110'1111)
.WithInterpretSequenceIndexAsMostSignificantBits(true) .WithInterpretSequenceIndexAsMostSignificantBits(true)
.WithStdDev(34.5098) // 220 / (255.0 * 40.0) .WithStdDev(34.5098) // 220 / 255.0 * 40.0
.WithLumaErrorThreshold(0b1110) .WithLumaErrorThreshold(0b1110)
.WithChromaErrorThreshold(0b1111) .WithChromaErrorThreshold(0b1111)
.WithSampleValues(kSampleValues) .WithSampleValues(kSampleValues)
@ -138,7 +139,7 @@ TEST(CorruptionDetectionExtensionTest,
CorruptionDetectionMessage::Builder() CorruptionDetectionMessage::Builder()
.WithSequenceIndex(0b0110'1111) .WithSequenceIndex(0b0110'1111)
.WithInterpretSequenceIndexAsMostSignificantBits(false) .WithInterpretSequenceIndexAsMostSignificantBits(false)
.WithStdDev(34.5098) // 220 / (255.0 * 40.0) .WithStdDev(34.5098) // 220 / 255.0 * 40.0
.WithLumaErrorThreshold(0b1110) .WithLumaErrorThreshold(0b1110)
.WithChromaErrorThreshold(0b1111) .WithChromaErrorThreshold(0b1111)
.WithSampleValues(kSampleValues) .WithSampleValues(kSampleValues)
@ -201,13 +202,10 @@ TEST(CorruptionDetectionExtensionTest,
EXPECT_EQ(message.sequence_index(), 0b0100'0100); EXPECT_EQ(message.sequence_index(), 0b0100'0100);
EXPECT_TRUE(message.interpret_sequence_index_as_most_significant_bits()); EXPECT_TRUE(message.interpret_sequence_index_as_most_significant_bits());
EXPECT_THAT(message.std_dev(), EXPECT_THAT(message.std_dev(),
DoubleEq(34.509803921568626)); // 220 / (255.0 * 40.0) DoubleEq(34.509803921568626)); // 220 / 255.0 * 40.0
EXPECT_EQ(message.luma_error_threshold(), 0b1110); EXPECT_EQ(message.luma_error_threshold(), 0b1110);
EXPECT_EQ(message.chroma_error_threshold(), 0b1111); EXPECT_EQ(message.chroma_error_threshold(), 0b1111);
EXPECT_EQ(message.sample_values().size(), sizeof(kSampleValues)); EXPECT_THAT(message.sample_values(), ElementsAreArray(kSampleValues));
for (size_t i = 0; i < sizeof(kSampleValues); ++i) {
EXPECT_EQ(message.sample_values()[i], kSampleValues[i]);
}
} }
TEST(CorruptionDetectionExtensionTest, TEST(CorruptionDetectionExtensionTest,
@ -227,13 +225,10 @@ TEST(CorruptionDetectionExtensionTest,
EXPECT_EQ(message.sequence_index(), 0b0100'0100); EXPECT_EQ(message.sequence_index(), 0b0100'0100);
EXPECT_FALSE(message.interpret_sequence_index_as_most_significant_bits()); EXPECT_FALSE(message.interpret_sequence_index_as_most_significant_bits());
EXPECT_THAT(message.std_dev(), EXPECT_THAT(message.std_dev(),
DoubleEq(34.509803921568626)); // 220 / (255.0 * 40.0) DoubleEq(34.509803921568626)); // 220 / 255.0 * 40.0
EXPECT_EQ(message.luma_error_threshold(), 0b1110); EXPECT_EQ(message.luma_error_threshold(), 0b1110);
EXPECT_EQ(message.chroma_error_threshold(), 0b1111); EXPECT_EQ(message.chroma_error_threshold(), 0b1111);
EXPECT_EQ(message.sample_values().size(), sizeof(kSampleValues)); EXPECT_THAT(message.sample_values(), ElementsAreArray(kSampleValues));
for (size_t i = 0; i < sizeof(kSampleValues); ++i) {
EXPECT_EQ(message.sample_values()[i], kSampleValues[i]);
}
} }
TEST(CorruptionDetectionExtensionTest, FailsToParseWhenGivenNullptrAsOutput) { TEST(CorruptionDetectionExtensionTest, FailsToParseWhenGivenNullptrAsOutput) {