From f2e9cab3835cd40009a6c01184e432eb3a81c0e2 Mon Sep 17 00:00:00 2001 From: Bjorn Terelius Date: Mon, 27 May 2019 16:44:09 +0200 Subject: [PATCH] Fix BWE simulation graph in event log visualization MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The simulation currently doesn't set the transport sequence number before inserting the packets into the send time history. This means that send times can't be looked up when receiving feedback, essentially disabling BWE simulation. Bug: None Change-Id: I3f2789324eb81f784dd5a6c5a5a770767236a3fc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138826 Reviewed-by: Sebastian Jansson Commit-Queue: Björn Terelius Cr-Commit-Position: refs/heads/master@{#28082} --- rtc_tools/event_log_visualizer/analyzer.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rtc_tools/event_log_visualizer/analyzer.cc b/rtc_tools/event_log_visualizer/analyzer.cc index 71c5f74bd4..b194207d5c 100644 --- a/rtc_tools/event_log_visualizer/analyzer.cc +++ b/rtc_tools/event_log_visualizer/analyzer.cc @@ -1288,7 +1288,7 @@ void EventLogAnalyzer::CreateSendSideBweSimulationGraph(Plot* plot) { RTC_DCHECK(rtp_packet.rtp.header.extension.hasTransportSequenceNumber); RtpPacketSendInfo packet_info; packet_info.ssrc = rtp_packet.rtp.header.ssrc; - packet_info.rtp_sequence_number = + packet_info.transport_sequence_number = rtp_packet.rtp.header.extension.transportSequenceNumber; packet_info.rtp_sequence_number = rtp_packet.rtp.header.sequenceNumber; packet_info.has_rtp_sequence_number = true;