admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete unused method SendSideBandwidthEstimation::UpdateReceiverBlock

Browse Source 
Bug: None
Change-Id: Ieca6dd99c7e5e06f1bb2306686a6a0f1e788e22f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153844
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29274}
This commit is contained in:
Niels Möller 2019-09-23 14:24:16 +02:00 committed by Commit Bot
parent bc646eee20
commit f2690a15b7
3 changed files with 7 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
modules/bitrate_controller/send_side_bandwidth_estimation.cc
View File

@ -353,18 +353,6 @@ void SendSideBandwidthEstimation::IncomingPacketFeedbackVector(
}
}
void SendSideBandwidthEstimation::UpdateReceiverBlock(uint8_t fraction_loss,
TimeDelta rtt,
int number_of_packets,
Timestamp at_time) {
const int kRoundingConstant = 128;
int packets_lost = (static_cast<int>(fraction_loss) * number_of_packets +
kRoundingConstant) >>
8;
UpdatePacketsLost(packets_lost, number_of_packets, at_time);
UpdateRtt(rtt, at_time);
}
void SendSideBandwidthEstimation::UpdatePacketsLost(int packets_lost,
int number_of_packets,
Timestamp at_time) {

6
modules/bitrate_controller/send_side_bandwidth_estimation.h
View File

@ -88,12 +88,6 @@ class SendSideBandwidthEstimation {
// Call when a new delay-based estimate is available.
void UpdateDelayBasedEstimate(Timestamp at_time, DataRate bitrate);
// Call when we receive a RTCP message with a ReceiveBlock.
void UpdateReceiverBlock(uint8_t fraction_loss,
TimeDelta rtt_ms,
int number_of_packets,
Timestamp at_time);
// Call when we receive a RTCP message with a ReceiveBlock.
void UpdatePacketsLost(int packets_lost,
int number_of_packets,

10
modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc
View File

@ -44,7 +44,9 @@ void TestProbing(bool use_delay_based) {
const int kRembBps = 1000000;
const int kSecondRembBps = kRembBps + 500000;
bwe.UpdateReceiverBlock(0, TimeDelta::ms(50), 1, Timestamp::ms(now_ms));
bwe.UpdatePacketsLost(/*packets_lost=*/0, /*number_of_packets=*/1,
Timestamp::ms(now_ms));
bwe.UpdateRtt(TimeDelta::ms(50), Timestamp::ms(now_ms));
// Initial REMB applies immediately.
if (use_delay_based) {
@ -110,8 +112,10 @@ TEST(SendSideBweTest, DoesntReapplyBitrateDecreaseWithoutFollowingRemb) {
EXPECT_EQ(0, rtt_ms);
// Signal heavy loss to go down in bitrate.
bwe.UpdateReceiverBlock(kFractionLoss, TimeDelta::ms(kRttMs), 100,
Timestamp::ms(now_ms));
bwe.UpdatePacketsLost(/*packets_lost=*/50, /*number_of_packets=*/100,
Timestamp::ms(now_ms));
bwe.UpdateRtt(TimeDelta::ms(kRttMs), Timestamp::ms(now_ms));
// Trigger an update 2 seconds later to not be rate limited.
now_ms += 1000;
bwe.UpdateEstimate(Timestamp::ms(now_ms));