From f24729bba785af16c102b155e4b3d514d65507b9 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Fri, 19 Jul 2019 12:05:09 +0200 Subject: [PATCH] Add usage message to rtc_event_log2rtp_dump. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:10616 Change-Id: I363715bedd28b9c74cefd3b4fd510f16963909f7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146210 Reviewed-by: Björn Terelius Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#28633} --- logging/BUILD.gn | 1 + .../rtc_event_log/rtc_event_log2rtp_dump.cc | 18 +++++++----------- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/logging/BUILD.gn b/logging/BUILD.gn index 194830e691..cd7caea239 100644 --- a/logging/BUILD.gn +++ b/logging/BUILD.gn @@ -411,6 +411,7 @@ if (rtc_enable_protobuf) { "../test:rtp_test_utils", "//third_party/abseil-cpp/absl/flags:flag", "//third_party/abseil-cpp/absl/flags:parse", + "//third_party/abseil-cpp/absl/flags:usage", "//third_party/abseil-cpp/absl/memory", "//third_party/abseil-cpp/absl/types:optional", ] diff --git a/logging/rtc_event_log/rtc_event_log2rtp_dump.cc b/logging/rtc_event_log/rtc_event_log2rtp_dump.cc index 9a82736ebe..114a1a0fe0 100644 --- a/logging/rtc_event_log/rtc_event_log2rtp_dump.cc +++ b/logging/rtc_event_log/rtc_event_log2rtp_dump.cc @@ -19,6 +19,7 @@ #include "absl/flags/flag.h" #include "absl/flags/parse.h" +#include "absl/flags/usage.h" #include "absl/memory/memory.h" #include "absl/types/optional.h" #include "api/array_view.h" @@ -164,19 +165,14 @@ void ConvertRtpPacket( // This utility will convert a stored event log to the rtpdump format. int main(int argc, char* argv[]) { - // TODO(bugs.webrtc.org/10616): Add program usage message when Abseil - // flags supports it. + absl::SetProgramUsageMessage( + "Tool for converting an RtcEventLog file to an " + "RTP dump file.\n" + "Example usage:\n" + "./rtc_event_log2rtp_dump input.rel output.rtp\n"); std::vector args = absl::ParseCommandLine(argc, argv); - std::string program_name = args[0]; - std::string usage = - "Tool for converting an RtcEventLog file to an RTP dump file.\n" - "Run " + - program_name + - " --help for usage.\n" - "Example usage:\n" + - program_name + " input.rel output.rtp\n"; if (args.size() != 3) { - std::cout << usage; + std::cout << absl::ProgramUsageMessage(); return 1; }