From f1d751c7dede158bc9770e4d7c4cb07191ffdf3f Mon Sep 17 00:00:00 2001
From: "jiayl@webrtc.org" <jiayl@webrtc.org>
Date: Thu, 25 Sep 2014 16:38:46 +0000
Subject: [PATCH] Call SSL_shutdown in OpenSSLStreamAdapter::Cleanup.

BUG=crbug/414211
R=juberti@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=7293

Review URL: https://webrtc-codereview.appspot.com/22739004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7301 4adac7df-926f-26a2-2b94-8c16560cd09d
---
 webrtc/base/opensslstreamadapter.cc      | 6 ++++++
 webrtc/base/sslstreamadapter_unittest.cc | 7 +++++++
 2 files changed, 13 insertions(+)

diff --git a/webrtc/base/opensslstreamadapter.cc b/webrtc/base/opensslstreamadapter.cc
index 070a948b14..133eb72b4c 100644
--- a/webrtc/base/opensslstreamadapter.cc
+++ b/webrtc/base/opensslstreamadapter.cc
@@ -695,6 +695,12 @@ void OpenSSLStreamAdapter::Cleanup() {
   }
 
   if (ssl_) {
+    int ret = SSL_shutdown(ssl_);
+    if (ret < 0) {
+      LOG(LS_WARNING) << "SSL_shutdown failed, error = "
+                      << SSL_get_error(ssl_, ret);
+    }
+
     SSL_free(ssl_);
     ssl_ = NULL;
   }
diff --git a/webrtc/base/sslstreamadapter_unittest.cc b/webrtc/base/sslstreamadapter_unittest.cc
index f7dcb71e48..053831437f 100644
--- a/webrtc/base/sslstreamadapter_unittest.cc
+++ b/webrtc/base/sslstreamadapter_unittest.cc
@@ -691,6 +691,13 @@ TEST_F(SSLStreamAdapterTestTLS, TestTLSConnect) {
   TestHandshake();
 };
 
+// Test that closing the connection on one side updates the other side.
+TEST_F(SSLStreamAdapterTestTLS, TestTLSClose) {
+  TestHandshake();
+  client_ssl_->Close();
+  EXPECT_EQ_WAIT(rtc::SS_CLOSED, server_ssl_->GetState(), handshake_wait_);
+};
+
 // Test transfer -- trivial
 TEST_F(SSLStreamAdapterTestTLS, TestTLSTransfer) {
   TestHandshake();