From f0e926fbdd8fcf9ca46d073ff375bb7169b6aaec Mon Sep 17 00:00:00 2001 From: tzik Date: Mon, 15 Oct 2018 13:52:10 +0900 Subject: [PATCH] Add missing #include and deps to absl/memory These files uses absl::WrapUnique or absl::make_unique without including absl/memory/memory.h. They used to include it indirectly via some other headers, but in C++17 mode, we need to include it explicitly. Bug: chromium:752720 Change-Id: Ic9a85a4844a71f8b8786c071f18d5b9cc301c26b Reviewed-on: https://webrtc-review.googlesource.com/c/105880 Reviewed-by: Mirko Bonadei Reviewed-by: Yves Gerey Reviewed-by: Karl Wiberg Commit-Queue: Taiju Tsuiki Cr-Commit-Position: refs/heads/master@{#25192} --- api/BUILD.gn | 1 + api/test/test_dependency_factory.cc | 1 + p2p/base/relayport.h | 1 + p2p/base/stunport.h | 1 + p2p/base/tcpport.h | 1 + p2p/base/turnport.h | 1 + 6 files changed, 6 insertions(+) diff --git a/api/BUILD.gn b/api/BUILD.gn index babc260160..5aee9486da 100644 --- a/api/BUILD.gn +++ b/api/BUILD.gn @@ -169,6 +169,7 @@ rtc_source_set("test_dependency_factory") { deps = [ ":video_quality_test_fixture_api", "../rtc_base:thread_checker", + "//third_party/abseil-cpp/absl/memory", ] if (!build_with_chromium && is_clang) { # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). diff --git a/api/test/test_dependency_factory.cc b/api/test/test_dependency_factory.cc index 3e59bc095c..179c623940 100644 --- a/api/test/test_dependency_factory.cc +++ b/api/test/test_dependency_factory.cc @@ -11,6 +11,7 @@ #include #include +#include "absl/memory/memory.h" #include "api/test/test_dependency_factory.h" #include "rtc_base/thread_checker.h" diff --git a/p2p/base/relayport.h b/p2p/base/relayport.h index 7c67915dc0..d45636f987 100644 --- a/p2p/base/relayport.h +++ b/p2p/base/relayport.h @@ -17,6 +17,7 @@ #include #include +#include "absl/memory/memory.h" #include "p2p/base/port.h" #include "p2p/base/stunrequest.h" diff --git a/p2p/base/stunport.h b/p2p/base/stunport.h index e719de4a6c..9c90ed9187 100644 --- a/p2p/base/stunport.h +++ b/p2p/base/stunport.h @@ -15,6 +15,7 @@ #include #include +#include "absl/memory/memory.h" #include "p2p/base/port.h" #include "p2p/base/stunrequest.h" #include "rtc_base/asyncpacketsocket.h" diff --git a/p2p/base/tcpport.h b/p2p/base/tcpport.h index 6a71d083ab..39823703ba 100644 --- a/p2p/base/tcpport.h +++ b/p2p/base/tcpport.h @@ -15,6 +15,7 @@ #include #include +#include "absl/memory/memory.h" #include "p2p/base/port.h" #include "rtc_base/asyncpacketsocket.h" diff --git a/p2p/base/turnport.h b/p2p/base/turnport.h index b4eb13d77d..f3f77a0308 100644 --- a/p2p/base/turnport.h +++ b/p2p/base/turnport.h @@ -19,6 +19,7 @@ #include #include +#include "absl/memory/memory.h" #include "p2p/base/port.h" #include "p2p/client/basicportallocator.h" #include "rtc_base/asyncinvoker.h"