admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make GetBitstream non-virtual since it is no longer needed for testing.

Browse Source 
Bug: webrtc:10979
Change-Id: Id313c7fddbec40b9f19dae95f736379b872e3082
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153663
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29242}
This commit is contained in:
philipel 2019-09-19 14:10:17 +02:00 committed by Commit Bot
parent 40de3cc5ef
commit f0be5b5380
4 changed files with 1 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
modules/video_coding/packet_buffer.h
View File

@ -114,8 +114,7 @@ class PacketBuffer {
RTC_EXCLUSIVE_LOCKS_REQUIRED(crit_); RTC_EXCLUSIVE_LOCKS_REQUIRED(crit_);
// Copy the bitstream for |frame| to |destination|. // Copy the bitstream for |frame| to |destination|.
// Virtual for testing. bool GetBitstream(const RtpFrameObject& frame, uint8_t* destination);
virtual bool GetBitstream(const RtpFrameObject& frame, uint8_t* destination);
// Get the packet with sequence number |seq_num|. // Get the packet with sequence number |seq_num|.
// Virtual for testing. // Virtual for testing.

5
modules/video_coding/rtp_frame_reference_finder_unittest.cc
View File

@ -40,11 +40,6 @@ class FakePacketBuffer : public PacketBuffer {
return true; return true;
} }
bool GetBitstream(const RtpFrameObject& frame,
uint8_t* destination) override {
return true;
}
private: private:
std::map<uint16_t, VCMPacket> packets_; std::map<uint16_t, VCMPacket> packets_;
}; };

5
test/fuzzers/rtp_frame_reference_finder_fuzzer.cc
View File

@ -100,11 +100,6 @@ class FuzzyPacketBuffer : public video_coding::PacketBuffer {
return packet; return packet;
} }
bool GetBitstream(const video_coding::RtpFrameObject& frame,
uint8_t* destination) override {
return true;
}
private: private:
std::map<uint16_t, VCMPacket> packets; std::map<uint16_t, VCMPacket> packets;
VideoCodecType codec; VideoCodecType codec;

5
video/buffered_frame_decryptor_unittest.cc
View File

@ -41,11 +41,6 @@ class FakePacketBuffer : public video_coding::PacketBuffer {
return true; return true;
} }
bool GetBitstream(const video_coding::RtpFrameObject& frame,
uint8_t* destination) override {
return true;
}
private: private:
std::map<uint16_t, VCMPacket> packets_; std::map<uint16_t, VCMPacket> packets_;
}; };