admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete kAlwaysAllowPayloadTypeDemuxingFieldTrialName flag.

Browse Source 
This flag was used as a kill switch in case turning off payload type
demuxing in some Unified Plan cases (https://crbug.com/webrtc/12814)
would cause any issues. That landed way back in M93 and no issues were
ever reported, so time to clean up the flag.

Bug: webrtc:12814
Change-Id: I1970936131384dc0be1cd118e6b0ac877b8c289c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253240
Auto-Submit: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36109}
This commit is contained in:
Henrik Boström 2022-03-02 10:12:56 +01:00 committed by WebRTC LUCI CQ
parent 1dfb9f4db6
commit f08e2663aa
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pc/sdp_offer_answer.cc
View File

@ -91,9 +91,6 @@ namespace {
typedef webrtc::PeerConnectionInterface::RTCOfferAnswerOptions
RTCOfferAnswerOptions;
constexpr const char* kAlwaysAllowPayloadTypeDemuxingFieldTrialName =
"WebRTC-AlwaysAllowPayloadTypeDemuxing";
// Error messages
const char kInvalidSdp[] = "Invalid session description.";
const char kInvalidCandidates[] = "Description contains invalid candidates.";
@ -5090,13 +5087,6 @@ bool SdpOfferAnswerHandler::UpdatePayloadTypeDemuxingState(
bool bundled_pt_demux_allowed_video = !IsUnifiedPlan() ||
mid_header_extension_missing_video ||
pt_demuxing_has_been_used_video_;
// Kill switch for the above change.
if (field_trial::IsEnabled(kAlwaysAllowPayloadTypeDemuxingFieldTrialName)) {
// TODO(https://crbug.com/webrtc/12814): If disabling PT-based demux does
// not trigger regressions, remove this kill switch.
bundled_pt_demux_allowed_audio = true;
bundled_pt_demux_allowed_video = true;
}
// Gather all updates ahead of time so that all channels can be updated in a
// single Invoke; necessary due to thread guards.