admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add histograms for send-side delay stats for a sent video stream:

Browse Source 
- "WebRTC.Video.SendSideDelayInMs"
- "WebRTC.Video.SendSideDelayMaxInMs"

BUG=chromium:512752

Review URL: https://codereview.webrtc.org/1405023014

Cr-Commit-Position: refs/heads/master@{#10502}
This commit is contained in:
asapersson 2015-11-04 00:59:03 -08:00 committed by Commit bot
parent c21f0c04cc
commit f040b2367d
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
webrtc/video/send_statistics_proxy.cc
View File

@ -121,6 +121,15 @@ void SendStatisticsProxy::UpdateHistograms() {
RTC_HISTOGRAM_ENUMERATION(
"WebRTC.Video.BandwidthLimitedResolutionsDisabled", num_disabled, 10);
}
int delay_ms = delay_counter_.Avg(kMinRequiredSamples);
if (delay_ms != -1)
RTC_HISTOGRAM_COUNTS_100000("WebRTC.Video.SendSideDelayInMs", delay_ms);
int max_delay_ms = max_delay_counter_.Avg(kMinRequiredSamples);
if (max_delay_ms != -1) {
RTC_HISTOGRAM_COUNTS_100000(
"WebRTC.Video.SendSideDelayMaxInMs", max_delay_ms);
}
}
void SendStatisticsProxy::OnOutgoingRate(uint32_t framerate, uint32_t bitrate) {
@ -337,6 +346,9 @@ void SendStatisticsProxy::SendSideDelayUpdated(int avg_delay_ms,
return;
stats->avg_delay_ms = avg_delay_ms;
stats->max_delay_ms = max_delay_ms;
delay_counter_.Add(avg_delay_ms);
max_delay_counter_.Add(max_delay_ms);
}
void SendStatisticsProxy::SampleCounter::Add(int sample) {

2
webrtc/video/send_statistics_proxy.h
View File

@ -142,6 +142,8 @@ class SendStatisticsProxy : public CpuOveruseMetricsObserver,
SampleCounter quality_downscales_counter_ GUARDED_BY(crit_);
BoolSampleCounter bw_limited_frame_counter_ GUARDED_BY(crit_);
SampleCounter bw_resolutions_disabled_counter_ GUARDED_BY(crit_);
SampleCounter delay_counter_ GUARDED_BY(crit_);
SampleCounter max_delay_counter_ GUARDED_BY(crit_);
};
} // namespace webrtc