admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove deprecated JsepSession initializer

Browse Source 
Also removes SessionDescription::Copy.

Bug: webrtc:10612
Change-Id: Ib652d717531738c3ed5d1054e32a03961e16dba9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/139903
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28239}
This commit is contained in:
Harald Alvestrand 2019-06-03 22:37:58 +02:00 committed by Commit Bot
parent f2b813a951
commit ef10a4ceb6
4 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
api/jsep_session_description.h
View File

@ -48,10 +48,6 @@ class JsepSessionDescription : public SessionDescriptionInterface {
bool Initialize(std::unique_ptr<cricket::SessionDescription> description, bool Initialize(std::unique_ptr<cricket::SessionDescription> description,
const std::string& session_id, const std::string& session_id,
const std::string& session_version); const std::string& session_version);
// Backwards compatible version. Replace with version above.
RTC_DEPRECATED bool Initialize(cricket::SessionDescription* description,
const std::string& session_id,
const std::string& session_version);
virtual cricket::SessionDescription* description() { virtual cricket::SessionDescription* description() {
return description_.get(); return description_.get();

7
pc/jsep_session_description.cc
View File

@ -198,13 +198,6 @@ bool JsepSessionDescription::Initialize(
return true; return true;
} }
bool JsepSessionDescription::Initialize(
cricket::SessionDescription* description,
const std::string& session_id,
const std::string& session_version) {
return Initialize(absl::WrapUnique(description), session_id, session_version);
}
bool JsepSessionDescription::AddCandidate( bool JsepSessionDescription::AddCandidate(
const IceCandidateInterface* candidate) { const IceCandidateInterface* candidate) {
if (!candidate) if (!candidate)

4
pc/session_description.cc
View File

@ -99,10 +99,6 @@ std::unique_ptr<SessionDescription> SessionDescription::Clone() const {
return absl::WrapUnique(new SessionDescription(*this)); return absl::WrapUnique(new SessionDescription(*this));
} }
SessionDescription* SessionDescription::Copy() const {
return Clone().release();
}
const ContentInfo* SessionDescription::GetContentByName( const ContentInfo* SessionDescription::GetContentByName(
const std::string& name) const { const std::string& name) const {
return FindContentInfoByName(contents_, name); return FindContentInfoByName(contents_, name);

3
pc/session_description.h
View File

@ -624,9 +624,6 @@ class SessionDescription {
~SessionDescription(); ~SessionDescription();
std::unique_ptr<SessionDescription> Clone() const; std::unique_ptr<SessionDescription> Clone() const;
// Older API - deprecated. Still expects caller to take ownership.
// Replace with Clone().
RTC_DEPRECATED SessionDescription* Copy() const;
struct MediaTransportSetting; struct MediaTransportSetting;