admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove nogncheck and add proper dependencies.

Browse Source 
Bug: webrtc:8733
Change-Id: I30224de3f9541c0c2652475c78c8889c10ec2121
Reviewed-on: https://webrtc-review.googlesource.com/39005
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21599}
This commit is contained in:
Patrik Höglund 2018-01-11 14:18:09 +01:00 committed by Commit Bot
parent cabe3838bb
commit eefd5439e7
4 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pc/BUILD.gn
View File

@ -191,8 +191,10 @@ rtc_static_library("peerconnection") {
"../call:call_interfaces",
"../common_video:common_video",
"../logging:rtc_event_log_api",
"../media:rtc_audio_video",
"../media:rtc_data",
"../media:rtc_media_base",
"../modules/audio_device",
"../p2p:rtc_p2p",
"../rtc_base:checks",
"../rtc_base:rtc_base",

3
pc/channel.cc
View File

@ -26,9 +26,6 @@
#include "rtc_base/networkroute.h"
#include "rtc_base/ptr_util.h"
#include "rtc_base/trace_event.h"
// Adding 'nogncheck' to disable the gn include headers check to support modular
// WebRTC build targets.
#include "media/engine/webrtcvoiceengine.h" // nogncheck
#include "p2p/base/packettransportinternal.h"
#include "pc/channelmanager.h"
#include "pc/rtpmediautils.h"

12
pc/peerconnectionfactory.cc
View File

@ -25,14 +25,10 @@
#include "rtc_base/bind.h"
#include "rtc_base/checks.h"
#include "rtc_base/ptr_util.h"
// Adding 'nogncheck' to disable the gn include headers check to support modular
// WebRTC build targets.
// TODO(zhihuang): This wouldn't be necessary if the interface and
// implementation of the media engine were in separate build targets.
#include "media/engine/webrtcmediaengine.h" // nogncheck
#include "media/engine/webrtcvideodecoderfactory.h" // nogncheck
#include "media/engine/webrtcvideoencoderfactory.h" // nogncheck
#include "modules/audio_device/include/audio_device.h" // nogncheck
#include "media/engine/webrtcmediaengine.h"
#include "media/engine/webrtcvideodecoderfactory.h"
#include "media/engine/webrtcvideoencoderfactory.h"
#include "modules/audio_device/include/audio_device.h"
#include "p2p/base/basicpacketsocketfactory.h"
#include "p2p/client/basicportallocator.h"
#include "pc/audiotrack.h"

4
pc/rtpsender.h
View File

@ -23,9 +23,7 @@
#include "api/rtpsenderinterface.h"
#include "rtc_base/basictypes.h"
#include "rtc_base/criticalsection.h"
// Adding 'nogncheck' to disable the gn include headers check to support modular
// WebRTC build targets.
#include "media/base/audiosource.h" // nogncheck
#include "media/base/audiosource.h"
#include "pc/channel.h"
#include "pc/dtmfsender.h"
#include "pc/statscollector.h"