From eefae3b7b7e664013d0bd8cec746033816f0f334 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Wed, 29 Jun 2022 15:51:11 +0000 Subject: [PATCH] Revert "Make the test library for field trials testonly." This reverts commit c33f1a828c31412e7422e7bf11db7c9b61fab339. Reason for revert: Breaks downstream project. Original change's description: > Make the test library for field trials testonly. > > Bug: None > Change-Id: I703a82e0ca10908bdc56c0d4f1455e042ce74ac1 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267163 > Reviewed-by: Artem Titov > Commit-Queue: Mirko Bonadei > Cr-Commit-Position: refs/heads/main@{#37371} Bug: None Change-Id: I1d6d88ed9f32d5f1aab3159bbd1f279f164a079d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267164 Commit-Queue: Mirko Bonadei Bot-Commit: rubber-stamper@appspot.gserviceaccount.com Owners-Override: Mirko Bonadei Cr-Commit-Position: refs/heads/main@{#37372} --- rtc_tools/BUILD.gn | 1 - test/BUILD.gn | 3 --- 2 files changed, 4 deletions(-) diff --git a/rtc_tools/BUILD.gn b/rtc_tools/BUILD.gn index b1bcbe17f4..1a56be8eb0 100644 --- a/rtc_tools/BUILD.gn +++ b/rtc_tools/BUILD.gn @@ -357,7 +357,6 @@ if (!build_with_chromium) { } rtc_library("event_log_visualizer_utils") { - testonly = true visibility = [ "*" ] sources = [ "rtc_event_log_visualizer/alerts.cc", diff --git a/test/BUILD.gn b/test/BUILD.gn index 5f2cc58c54..4e4107667b 100644 --- a/test/BUILD.gn +++ b/test/BUILD.gn @@ -215,7 +215,6 @@ rtc_library("rtp_test_utils") { } rtc_library("field_trial") { - testonly = true visibility = [ "*" ] sources = [ "field_trial.cc", @@ -230,7 +229,6 @@ rtc_library("field_trial") { } rtc_library("explicit_key_value_config") { - testonly = true sources = [ "explicit_key_value_config.cc", "explicit_key_value_config.h", @@ -245,7 +243,6 @@ rtc_library("explicit_key_value_config") { } rtc_library("scoped_key_value_config") { - testonly = true visibility = [ "*" ] sources = [ "scoped_key_value_config.cc",