From ee9d61ce4547d1704a70548890e7c447d14bbe7e Mon Sep 17 00:00:00 2001 From: "tkchin@webrtc.org" Date: Wed, 5 Nov 2014 22:01:53 +0000 Subject: [PATCH] This fixes a small memory leak (found using Xcode/Instruments on iOS) in the ObjC bindings of PeerConnection. The generated session description has to be released by the recipient BUG=3985 R=tkchin@webrtc.org Review URL: https://webrtc-codereview.appspot.com/28959004 Patch from Matthias Liebig . git-svn-id: http://webrtc.googlecode.com/svn/trunk@7636 4adac7df-926f-26a2-2b94-8c16560cd09d --- AUTHORS | 1 + talk/app/webrtc/objc/RTCPeerConnection.mm | 1 + 2 files changed, 2 insertions(+) diff --git a/AUTHORS b/AUTHORS index 07b7269808..abe78142dc 100644 --- a/AUTHORS +++ b/AUTHORS @@ -14,6 +14,7 @@ Jie Mao Luke Weber Manish Jethani Martin Storsjo +Matthias Liebig Pali Rohar Paul Kapustin Rafael Lopez Diez diff --git a/talk/app/webrtc/objc/RTCPeerConnection.mm b/talk/app/webrtc/objc/RTCPeerConnection.mm index 925de73392..7767f7619d 100644 --- a/talk/app/webrtc/objc/RTCPeerConnection.mm +++ b/talk/app/webrtc/objc/RTCPeerConnection.mm @@ -68,6 +68,7 @@ class RTCCreateSessionDescriptionObserver [_delegate peerConnection:_peerConnection didCreateSessionDescription:session error:nil]; + delete desc; } virtual void OnFailure(const std::string& error) OVERRIDE {