From ee58849235967f50ee66dce87595eea3287b3569 Mon Sep 17 00:00:00 2001 From: Palak Agarwal Date: Fri, 9 Jun 2023 11:28:40 +0200 Subject: [PATCH] Make SetRTPTimestamp pure virtual in TransformableAudioFrameInterface This can be done now as the function SetRTPTimestamp is now overriden in blink MockTransformableAudioFrame. Change-Id: I4fa4cb81d0282fea864818f0f2d9a5ed881a5d30 Bug: webrtc:14709 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/308361 Reviewed-by: Harald Alvestrand Commit-Queue: Palak Agarwal Cr-Commit-Position: refs/heads/main@{#40257} --- api/frame_transformer_interface.h | 2 +- api/test/mock_transformable_audio_frame.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/api/frame_transformer_interface.h b/api/frame_transformer_interface.h index bfe3b0235b..d4b09a46e2 100644 --- a/api/frame_transformer_interface.h +++ b/api/frame_transformer_interface.h @@ -68,11 +68,11 @@ class TransformableAudioFrameInterface : public TransformableFrameInterface { public: virtual ~TransformableAudioFrameInterface() = default; + virtual void SetRTPTimestamp(uint32_t timestamp) = 0; // Exposes the frame header, enabling the interface clients to use the // information in the header as needed, for example to compile the list of // csrcs. virtual const RTPHeader& GetHeader() const = 0; - virtual void SetRTPTimestamp(uint32_t timestamp) { RTC_CHECK_NOTREACHED(); } virtual rtc::ArrayView GetContributingSources() const = 0; }; diff --git a/api/test/mock_transformable_audio_frame.h b/api/test/mock_transformable_audio_frame.h index c8d24f079d..912488adbc 100644 --- a/api/test/mock_transformable_audio_frame.h +++ b/api/test/mock_transformable_audio_frame.h @@ -20,11 +20,11 @@ class MockTransformableAudioFrame : public TransformableAudioFrameInterface { public: MOCK_METHOD(rtc::ArrayView, GetData, (), (const, override)); MOCK_METHOD(void, SetData, (rtc::ArrayView), (override)); + MOCK_METHOD(void, SetRTPTimestamp, (uint32_t), (override)); MOCK_METHOD(uint8_t, GetPayloadType, (), (const, override)); MOCK_METHOD(uint32_t, GetSsrc, (), (const, override)); MOCK_METHOD(uint32_t, GetTimestamp, (), (const, override)); MOCK_METHOD(RTPHeader&, GetHeader, (), (const override)); - MOCK_METHOD(void, SetRTPTimestamp, (uint32_t), (override)); MOCK_METHOD(rtc::ArrayView, GetContributingSources, (),