From ee1e6bcb02a362090717b6c7a04fd27d37072365 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Wed, 15 Apr 2020 20:57:37 +0200 Subject: [PATCH] Remove deprecated VideoSendStream::StreamStats data members. Bug: webrtc:10198 Change-Id: Ie48727acc6d1c9af42f3a997c98d9fdab4675d4a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173622 Reviewed-by: Magnus Flodman Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#31080} --- call/video_send_stream.h | 7 ------- video/send_statistics_proxy.cc | 6 ------ 2 files changed, 13 deletions(-) diff --git a/call/video_send_stream.h b/call/video_send_stream.h index 08806ec2ec..86f310229a 100644 --- a/call/video_send_stream.h +++ b/call/video_send_stream.h @@ -83,13 +83,6 @@ class VideoSendStream { // A snapshot of the most recent Report Block with additional data of // interest to statistics. Used to implement RTCRemoteInboundRtpStreamStats. absl::optional report_block_data; - - // These booleans are redundant; this information is already exposed in - // |type|. - // TODO(hbos): Update downstream projects to use |type| instead and delete - // these members. - bool is_flexfec = false; - bool is_rtx = false; }; struct Stats { diff --git a/video/send_statistics_proxy.cc b/video/send_statistics_proxy.cc index e75b955b20..f2cdbc9602 100644 --- a/video/send_statistics_proxy.cc +++ b/video/send_statistics_proxy.cc @@ -792,18 +792,12 @@ VideoSendStream::StreamStats* SendStatisticsProxy::GetStatsEntry( case VideoSendStream::StreamStats::StreamType::kRtx: entry->referenced_media_ssrc = rtp_config_.GetMediaSsrcAssociatedWithRtxSsrc(ssrc); - entry->is_rtx = true; break; case VideoSendStream::StreamStats::StreamType::kFlexfec: entry->referenced_media_ssrc = rtp_config_.GetMediaSsrcAssociatedWithFlexfecSsrc(ssrc); - entry->is_flexfec = true; break; } - // TODO(hbos): Remove these booleans once downstream projects stop depedning - // on them, reading the value of |type| instead. - RTC_DCHECK_EQ(entry->is_rtx, is_rtx); - RTC_DCHECK_EQ(entry->is_flexfec, is_flexfec); return entry; }