admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove Crit::Scope lock by using atomic bool property.

Browse Source 
The clang static analyzer seems unable to resolve cpp locks in ObjC code.
As of current time, the clang analyzer has known limitations documented
http://clang.llvm.org/docs/ThreadSafetyAnalysis.html#known-limitations.
From the documentation: "The analysis currently does not do any checking
inside constructors or destructors.
In other words, every constructor and destructor is treated
as if it was annotated with NO_THREAD_SAFETY_ANALYSIS."
This is 'probably' why the analyzer is unable to resolve the lock when
used in ObjC land (the cpp works fine).
The lock can be removed by using atomic property instead.
It's not on performance critical path and we expect updates on just one queue and reads from others. That's why the thread assurance atomic properties bring is enough.
The CL removes rtc_sdk_peerconnection_objc_warnings_config as well as it's no longer needed.

BUG=webrtc:6308

Review-Url: https://codereview.webrtc.org/2372513004
Cr-Commit-Position: refs/heads/master@{#14450}
This commit is contained in:
denicija 2016-09-30 00:21:11 -07:00 committed by Commit bot
parent eb5040ae44
commit edbae5e0ac
2 changed files with 4 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
webrtc/sdk/BUILD.gn
View File

@ -68,15 +68,6 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
}
}
config("rtc_sdk_peerconnection_objc_warnings_config") {
if (is_clang) {
# TODO(tkchin): Make rtc_sdk_peerconnection_objc compile with the standard
# set of warnings.
# See https://bugs.chromium.org/p/webrtc/issues/detail?id=6308
cflags = [ "-Wno-thread-safety-analysis" ]
}
}
rtc_static_library("rtc_sdk_peerconnection_objc") {
sources = [
"objc/Framework/Classes/RTCAVFoundationVideoSource+Private.h",
@ -194,7 +185,6 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
}
configs += [
":rtc_sdk_peerconnection_objc_warnings_config",
"..:common_objc",
"//build/config/compiler:enable_arc",
]

15
webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm
View File

@ -78,7 +78,7 @@ static NSString *GetSessionPresetForVideoFormat(
@property(nonatomic, readonly) dispatch_queue_t frameQueue;
@property(nonatomic, readonly) BOOL canUseBackCamera;
@property(nonatomic, assign) BOOL useBackCamera; // Defaults to NO.
@property(nonatomic, assign) BOOL isRunning; // Whether the capture session is running.
@property(atomic, assign) BOOL isRunning; // Whether the capture session is running.
@property(atomic, assign) BOOL hasStarted; // Whether we have an unmatched start.
// We keep a pointer back to AVFoundationVideoCapturer to make callbacks on it
@ -111,6 +111,8 @@ static NSString *GetSessionPresetForVideoFormat(
@synthesize captureSession = _captureSession;
@synthesize frameQueue = _frameQueue;
@synthesize useBackCamera = _useBackCamera;
@synthesize isRunning = _isRunning;
@synthesize hasStarted = _hasStarted;
// This is called from the thread that creates the video source, which is likely
@ -217,16 +219,6 @@ static NSString *GetSessionPresetForVideoFormat(
}
}
- (BOOL)isRunning {
rtc::CritScope cs(&_crit);
return _isRunning;
}
- (void)setIsRunning:(BOOL)isRunning {
rtc::CritScope cs(&_crit);
_isRunning = isRunning;
}
// Called from WebRTC thread.
- (void)start {
if (self.hasStarted) {
@ -355,6 +347,7 @@ static NSString *GetSessionPresetForVideoFormat(
- (void)handleCaptureSessionDidStartRunning:(NSNotification *)notification {
RTCLog(@"Capture session started.");
self.isRunning = YES;
[RTCDispatcher dispatchAsyncOnType:RTCDispatcherTypeCaptureSession
block:^{