From ed69d41b62cc7c036e1be6c400e2a8b5bf6cf07d Mon Sep 17 00:00:00 2001 From: Danil Chapovalov Date: Wed, 29 May 2019 10:24:36 +0200 Subject: [PATCH] Remove deprecated RtcEventLog Create functions Bug: webrtc:10206 Change-Id: Iabf3eea20027ae42faadabba572dc68f9b678121 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/139105 Reviewed-by: Karl Wiberg Commit-Queue: Danil Chapovalov Cr-Commit-Position: refs/heads/master@{#28103} --- api/rtc_event_log/BUILD.gn | 2 -- api/rtc_event_log/rtc_event_log.h | 18 +----------------- api/rtc_event_log/rtc_event_log_factory.cc | 6 ------ 3 files changed, 1 insertion(+), 25 deletions(-) diff --git a/api/rtc_event_log/BUILD.gn b/api/rtc_event_log/BUILD.gn index 70074938b2..c04ca6492b 100644 --- a/api/rtc_event_log/BUILD.gn +++ b/api/rtc_event_log/BUILD.gn @@ -21,10 +21,8 @@ rtc_source_set("rtc_event_log") { deps = [ "..:libjingle_logging_api", "../../rtc_base:checks", - "../../rtc_base:deprecation", "../../rtc_base:timeutils", "../task_queue", - "//third_party/abseil-cpp/absl/memory", ] } diff --git a/api/rtc_event_log/rtc_event_log.h b/api/rtc_event_log/rtc_event_log.h index 05589b1e40..cebaf84e40 100644 --- a/api/rtc_event_log/rtc_event_log.h +++ b/api/rtc_event_log/rtc_event_log.h @@ -13,13 +13,12 @@ #include #include +#include #include -#include "absl/memory/memory.h" #include "api/rtc_event_log/rtc_event.h" #include "api/rtc_event_log_output.h" #include "api/task_queue/task_queue_factory.h" -#include "rtc_base/deprecation.h" namespace webrtc { @@ -32,17 +31,6 @@ class RtcEventLog { // clients have migrated to the new format. enum class EncodingType { Legacy, NewFormat }; - // Factory method to create an RtcEventLog object. - // Create RtcEventLog with an RtcEventLogFactory instead. - RTC_DEPRECATED - static std::unique_ptr Create( - EncodingType encoding_type, - TaskQueueFactory* task_queue_factory); - - // Create an RtcEventLog object that does nothing. - RTC_DEPRECATED - static std::unique_ptr CreateNull(); - virtual ~RtcEventLog() = default; // Starts logging to a given output. The output might be limited in size, @@ -76,10 +64,6 @@ class RtcEventLogNull final : public RtcEventLog { void Log(std::unique_ptr event) override {} }; -inline std::unique_ptr RtcEventLog::CreateNull() { - return absl::make_unique(); -} - } // namespace webrtc #endif // API_RTC_EVENT_LOG_RTC_EVENT_LOG_H_ diff --git a/api/rtc_event_log/rtc_event_log_factory.cc b/api/rtc_event_log/rtc_event_log_factory.cc index 188de15068..da03e93dd5 100644 --- a/api/rtc_event_log/rtc_event_log_factory.cc +++ b/api/rtc_event_log/rtc_event_log_factory.cc @@ -35,10 +35,4 @@ std::unique_ptr RtcEventLogFactory::CreateRtcEventLog( #endif } -std::unique_ptr RtcEventLog::Create( - RtcEventLog::EncodingType encoding_type, - TaskQueueFactory* task_queue_factory) { - return RtcEventLogFactory(task_queue_factory) - .CreateRtcEventLog(encoding_type); -} } // namespace webrtc