From ed050bf253b7d21b856fcedab87a872e60de873e Mon Sep 17 00:00:00 2001 From: Evan Shrubsole Date: Tue, 12 Mar 2024 14:53:04 +0000 Subject: [PATCH] Remove TRACE_ASYNC without matching TRACE_BEGIN in rtc_sender_video This seems to confuse perfetto, and the data ends up on its own track and the end event is just ignored. As it was invalid, I am assuming it is not used, and can be simply removed. #rtc_fixit Bug: webrtc:15867 Change-Id: I31a814f6c2147c3ce534726bf9046a79369b9eb3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/342761 Reviewed-by: Mirko Bonadei Reviewed-by: Danil Chapovalov Commit-Queue: Evan Shrubsole Cr-Commit-Position: refs/heads/main@{#41896} --- modules/rtp_rtcp/source/rtp_sender_video.cc | 6 ------ 1 file changed, 6 deletions(-) diff --git a/modules/rtp_rtcp/source/rtp_sender_video.cc b/modules/rtp_rtcp/source/rtp_sender_video.cc index ebca7aaa75..e02d18cc46 100644 --- a/modules/rtp_rtcp/source/rtp_sender_video.cc +++ b/modules/rtp_rtcp/source/rtp_sender_video.cc @@ -42,7 +42,6 @@ #include "rtc_base/checks.h" #include "rtc_base/experiments/field_trial_parser.h" #include "rtc_base/logging.h" -#include "rtc_base/trace_event.h" namespace webrtc { @@ -464,9 +463,6 @@ bool RTPSenderVideo::SendVideo(int payload_type, RTPVideoHeader video_header, TimeDelta expected_retransmission_time, std::vector csrcs) { - TRACE_EVENT_ASYNC_STEP1( - "webrtc", "Video", capture_time.ms_or(0), "Send", "type", - std::string(VideoFrameTypeToString(video_header.frame_type))); RTC_CHECK_RUNS_SERIALIZED(&send_checker_); if (video_header.frame_type == VideoFrameType::kEmptyFrame) @@ -743,8 +739,6 @@ bool RTPSenderVideo::SendVideo(int payload_type, send_allocation_ = SendVideoLayersAllocation::kDontSend; } - TRACE_EVENT_ASYNC_END1("webrtc", "Video", capture_time.ms_or(0), "timestamp", - rtp_timestamp); return true; }