admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Comment unused variables in implemented functions 2\n

Browse Source 
Bug: webrtc:370878648
Change-Id: Idcead9b143b65d6f5f42187d1bd3bf75227c765f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/364504
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43159}
This commit is contained in:
Dor Hen 2024-10-02 12:31:52 -07:00 committed by WebRTC LUCI CQ
parent f653f476f0
commit eca11ca18b
4 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
rtc_base/event_tracer.cc
View File

@ -129,7 +129,7 @@ class EventLogger final {
const unsigned char* arg_types, const unsigned char* arg_types,
const unsigned long long* arg_values, const unsigned long long* arg_values,
uint64_t timestamp, uint64_t timestamp,
int pid, int /* pid */,
rtc::PlatformThreadId thread_id) { rtc::PlatformThreadId thread_id) {
std::vector<TraceArg> args(num_args); std::vector<TraceArg> args(num_args);
for (int i = 0; i < num_args; ++i) { for (int i = 0; i < num_args; ++i) {
@ -379,12 +379,12 @@ const unsigned char* InternalEnableAllCategories(const char* name) {
void InternalAddTraceEvent(char phase, void InternalAddTraceEvent(char phase,
const unsigned char* category_enabled, const unsigned char* category_enabled,
const char* name, const char* name,
unsigned long long id, unsigned long long /* id */,
int num_args, int num_args,
const char** arg_names, const char** arg_names,
const unsigned char* arg_types, const unsigned char* arg_types,
const unsigned long long* arg_values, const unsigned long long* arg_values,
unsigned char flags) { unsigned char /* flags */) {
// Fast path for when event tracing is inactive. // Fast path for when event tracing is inactive.
if (g_event_logging_active.load() == 0) if (g_event_logging_active.load() == 0)
return; return;

2
rtc_base/null_socket_server.cc
View File

@ -21,7 +21,7 @@ NullSocketServer::NullSocketServer() = default;
NullSocketServer::~NullSocketServer() {} NullSocketServer::~NullSocketServer() {}
bool NullSocketServer::Wait(webrtc::TimeDelta max_wait_duration, bool NullSocketServer::Wait(webrtc::TimeDelta max_wait_duration,
bool process_io) { bool /* process_io */) {
// Wait with the given timeout. Do not log a warning if we end up waiting for // Wait with the given timeout. Do not log a warning if we end up waiting for
// a long time; that just means no one has any work for us, which is perfectly // a long time; that just means no one has any work for us, which is perfectly
// legitimate. // legitimate.

3
rtc_base/openssl_utility.cc
View File

@ -42,7 +42,8 @@ namespace {
// TODO(crbug.com/webrtc/11710): When OS certificate verification is available, // TODO(crbug.com/webrtc/11710): When OS certificate verification is available,
// and we don't need VerifyPeerCertMatchesHost, don't compile this in order to // and we don't need VerifyPeerCertMatchesHost, don't compile this in order to
// avoid a dependency on OpenSSL X509 objects (see crbug.com/webrtc/11410). // avoid a dependency on OpenSSL X509 objects (see crbug.com/webrtc/11410).
void LogCertificates(SSL* ssl, X509* certificate) { void LogCertificates([[maybe_unused]] SSL* ssl,
[[maybe_unused]] X509* certificate) {
// Logging certificates is extremely verbose. So it is disabled by default. // Logging certificates is extremely verbose. So it is disabled by default.
#ifdef LOG_CERTIFICATES #ifdef LOG_CERTIFICATES
BIO* mem = BIO_new(BIO_s_mem()); BIO* mem = BIO_new(BIO_s_mem());

2
rtc_base/socket_server.h
View File

@ -39,7 +39,7 @@ class SocketServer : public SocketFactory {
// to allow the socket server to use the thread's message queue for any // to allow the socket server to use the thread's message queue for any
// messaging that it might need to perform. It is also called with a null // messaging that it might need to perform. It is also called with a null
// argument before the thread is destroyed. // argument before the thread is destroyed.
virtual void SetMessageQueue(Thread* queue) {} virtual void SetMessageQueue(Thread* /* queue */) {}
// Sleeps until: // Sleeps until:
// 1) `max_wait_duration` has elapsed (unless `max_wait_duration` == // 1) `max_wait_duration` has elapsed (unless `max_wait_duration` ==