From ec086d842ce777a5cb8983458d85a44cde9622b4 Mon Sep 17 00:00:00 2001 From: Sebastian Jansson Date: Mon, 3 Dec 2018 17:46:21 +0100 Subject: [PATCH] Fixes race in SendSideCongestionControllerTest.OldFeedback. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This fixes an issue where SendSideCongestionControllerTest.OldFeedback calls a function that posts a task on a TaskQueue and immediately after changes the mocked observer that is called from that task. Bug: webrtc:10056 Change-Id: Ib1cca5bf695482e75106bfc715662e4f76c381d9 Reviewed-on: https://webrtc-review.googlesource.com/c/112940 Reviewed-by: Björn Terelius Commit-Queue: Sebastian Jansson Cr-Commit-Position: refs/heads/master@{#25882} --- .../rtp/send_side_congestion_controller_unittest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/congestion_controller/rtp/send_side_congestion_controller_unittest.cc b/modules/congestion_controller/rtp/send_side_congestion_controller_unittest.cc index 6ed7a49553..64a5234873 100644 --- a/modules/congestion_controller/rtp/send_side_congestion_controller_unittest.cc +++ b/modules/congestion_controller/rtp/send_side_congestion_controller_unittest.cc @@ -302,7 +302,7 @@ TEST_F(SendSideCongestionControllerTest, OldFeedback) { feedback.Build(); controller_->OnTransportFeedback(feedback); } - + controller_->WaitOnTasks(); // If the bitrate is reset to -1, the new starting bitrate will be // the minimum default bitrate kMinBitrateBps. EXPECT_CALL(