From ebb0b8ec9a669c050b27cde5ef0779f5ad39ba76 Mon Sep 17 00:00:00 2001 From: ehmaldonado Date: Tue, 4 Oct 2016 01:58:57 -0700 Subject: [PATCH] Increase the threshold for RunPlayoutAndRecordingInFullDuplex. RunPlayoutAndRecordingInFullDuplex fails sometimes on Android swarming bots, presumably because the timing is hardware dependent. This test ensures that audio starts pumping. The exact performance is not that important. R=kjellander@webrtc.org, henrika@webrtc.org BUG=webrtc:6464 NOTRY=True Review-Url: https://codereview.webrtc.org/2391563002 Cr-Commit-Position: refs/heads/master@{#14492} --- .../modules/audio_device/android/audio_device_unittest.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/webrtc/modules/audio_device/android/audio_device_unittest.cc b/webrtc/modules/audio_device/android/audio_device_unittest.cc index 56fb209d02..eefab0f4e1 100644 --- a/webrtc/modules/audio_device/android/audio_device_unittest.cc +++ b/webrtc/modules/audio_device/android/audio_device_unittest.cc @@ -1020,8 +1020,12 @@ TEST_F(AudioDeviceTest, RunPlayoutAndRecordingInFullDuplex) { 1000 * kFullDuplexTimeInSec)); StopPlayout(); StopRecording(); - EXPECT_LE(fifo_audio_stream->average_size(), 10u); - EXPECT_LE(fifo_audio_stream->largest_size(), 20u); + + // These thresholds are set rather high to accomodate differences in hardware + // in several devices, so this test can be used in swarming. + // See http://bugs.webrtc.org/6464 + EXPECT_LE(fifo_audio_stream->average_size(), 30u); + EXPECT_LE(fifo_audio_stream->largest_size(), 40u); } // Measures loopback latency and reports the min, max and average values for