admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Dont use simulcast for AV1.

Browse Source 
Bug: none
Change-Id: I9d3bfb3bff497db740e317fcad0e8f91bfa88d1c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234744
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35177}
This commit is contained in:
philipel 2021-10-11 11:18:48 +02:00 committed by WebRTC LUCI CQ
parent 52d97fd4cf
commit eb42ab77cf
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
media/engine/webrtc_video_engine.cc
View File

@ -296,10 +296,16 @@ static bool ValidateStreamParams(const StreamParams& sp) {
// Returns true if the given codec is disallowed from doing simulcast.
bool IsCodecDisabledForSimulcast(const std::string& codec_name,
const webrtc::WebRtcKeyValueConfig& trials) {
return !absl::StartsWith(trials.Lookup("WebRTC-H264Simulcast"), "Disabled")
? absl::EqualsIgnoreCase(codec_name, kVp9CodecName)
: absl::EqualsIgnoreCase(codec_name, kH264CodecName) ||
absl::EqualsIgnoreCase(codec_name, kVp9CodecName);
if (absl::EqualsIgnoreCase(codec_name, kVp9CodecName) ||
absl::EqualsIgnoreCase(codec_name, kAv1CodecName)) {
return true;
}
if (absl::EqualsIgnoreCase(codec_name, kH264CodecName)) {
return absl::StartsWith(trials.Lookup("WebRTC-H264Simulcast"), "Disabled");
}
return false;
}
// The selected thresholds for QVGA and VGA corresponded to a QP around 10.