From eb03d286dfc7bea541b480ae098e87245a1833d8 Mon Sep 17 00:00:00 2001 From: Tommi Date: Thu, 2 Apr 2020 22:59:29 +0200 Subject: [PATCH] Remove seemingly unused timer Bug: none Change-Id: I47cb2a22e6d62e0bfd094fc6246a27b48286b33d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172801 Reviewed-by: Philip Eliasson Commit-Queue: Tommi Cr-Commit-Position: refs/heads/master@{#30995} --- modules/video_coding/video_coding_impl.h | 1 - modules/video_coding/video_receiver.cc | 14 +------------- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/modules/video_coding/video_coding_impl.h b/modules/video_coding/video_coding_impl.h index 89353640d6..eaab639dbf 100644 --- a/modules/video_coding/video_coding_impl.h +++ b/modules/video_coding/video_coding_impl.h @@ -124,7 +124,6 @@ class VideoReceiver : public Module { // over to the decoder thread. VCMDecoderDataBase _codecDataBase; - VCMProcessTimer _receiveStatsTimer RTC_GUARDED_BY(module_thread_checker_); VCMProcessTimer _retransmissionTimer RTC_GUARDED_BY(module_thread_checker_); VCMProcessTimer _keyRequestTimer RTC_GUARDED_BY(module_thread_checker_); ThreadUnsafeOneTimeEvent first_frame_received_ diff --git a/modules/video_coding/video_receiver.cc b/modules/video_coding/video_receiver.cc index 44d5526a0a..a817293f2f 100644 --- a/modules/video_coding/video_receiver.cc +++ b/modules/video_coding/video_receiver.cc @@ -53,7 +53,6 @@ VideoReceiver::VideoReceiver(Clock* clock, VCMTiming* timing) drop_frames_until_keyframe_(false), max_nack_list_size_(0), _codecDataBase(), - _receiveStatsTimer(1000, clock_), _retransmissionTimer(10, clock_), _keyRequestTimer(500, clock_) { decoder_thread_checker_.Detach(); @@ -66,13 +65,6 @@ VideoReceiver::~VideoReceiver() { void VideoReceiver::Process() { RTC_DCHECK_RUN_ON(&module_thread_checker_); - // Receive-side statistics - - // TODO(philipel): Remove this if block when we know what to do with - // ReceiveStatisticsProxy::QualitySample. - if (_receiveStatsTimer.TimeUntilProcess() == 0) { - _receiveStatsTimer.Processed(); - } // Key frame requests if (_keyRequestTimer.TimeUntilProcess() == 0) { @@ -124,11 +116,7 @@ void VideoReceiver::ProcessThreadAttached(ProcessThread* process_thread) { int64_t VideoReceiver::TimeUntilNextProcess() { RTC_DCHECK_RUN_ON(&module_thread_checker_); - int64_t timeUntilNextProcess = _receiveStatsTimer.TimeUntilProcess(); - // We need a Process call more often if we are relying on - // retransmissions - timeUntilNextProcess = - VCM_MIN(timeUntilNextProcess, _retransmissionTimer.TimeUntilProcess()); + int64_t timeUntilNextProcess = _retransmissionTimer.TimeUntilProcess(); timeUntilNextProcess = VCM_MIN(timeUntilNextProcess, _keyRequestTimer.TimeUntilProcess());