From e9dc70b22021a00a527fb42e0fe61ce1f5ff39f9 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Sat, 10 Dec 2022 11:39:29 +0100 Subject: [PATCH] Remove webrtc::webrtc_pc_e2e::GetCurrentTestName(). After https://webrtc-review.googlesource.com/c/src/+/287126, this is not neeed anymore. Bug: b/237982523, webrtc:14757 Change-Id: Ia91f2b09862d7d705d07f10f71f02b41f3c1c096 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/287128 Reviewed-by: Artem Titov Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/main@{#38869} --- test/pc/e2e/BUILD.gn | 6 +----- test/pc/e2e/metric_metadata_keys.cc | 27 --------------------------- test/pc/e2e/metric_metadata_keys.h | 6 ------ 3 files changed, 1 insertion(+), 38 deletions(-) delete mode 100644 test/pc/e2e/metric_metadata_keys.cc diff --git a/test/pc/e2e/BUILD.gn b/test/pc/e2e/BUILD.gn index 5a81e12dad..2b9a69afc5 100644 --- a/test/pc/e2e/BUILD.gn +++ b/test/pc/e2e/BUILD.gn @@ -10,11 +10,7 @@ import("../../../webrtc.gni") rtc_library("metric_metadata_keys") { testonly = true - sources = [ - "metric_metadata_keys.cc", - "metric_metadata_keys.h", - ] - deps = [ "../..:test_support" ] + sources = [ "metric_metadata_keys.h" ] } if (!build_with_chromium) { diff --git a/test/pc/e2e/metric_metadata_keys.cc b/test/pc/e2e/metric_metadata_keys.cc deleted file mode 100644 index cc57491d91..0000000000 --- a/test/pc/e2e/metric_metadata_keys.cc +++ /dev/null @@ -1,27 +0,0 @@ -/* - * Copyright (c) 2022 The WebRTC project authors. All Rights Reserved. - * - * Use of this source code is governed by a BSD-style license - * that can be found in the LICENSE file in the root of the source - * tree. An additional intellectual property rights grant can be found - * in the file PATENTS. All contributing project authors may - * be found in the AUTHORS file in the root of the source tree. - */ - -#include "test/pc/e2e/metric_metadata_keys.h" - -#include - -#include "test/gtest.h" - -namespace webrtc { -namespace webrtc_pc_e2e { - -std::string GetCurrentTestName() { - const testing::TestInfo* test_info = - testing::UnitTest::GetInstance()->current_test_info(); - return test_info->name(); -} - -} // namespace webrtc_pc_e2e -} // namespace webrtc diff --git a/test/pc/e2e/metric_metadata_keys.h b/test/pc/e2e/metric_metadata_keys.h index d07d4ca0ac..2fee0cbcb0 100644 --- a/test/pc/e2e/metric_metadata_keys.h +++ b/test/pc/e2e/metric_metadata_keys.h @@ -15,12 +15,6 @@ namespace webrtc { namespace webrtc_pc_e2e { -// TODO(bugs.webrtc.org/14757): Move this function to a better location once -// kExperimentalTestNameMetadataKey has been removed (this is here just for -// convenience since it is the value of the kExperimentalTestNameMetadataKey -// metadata entries). -std::string GetCurrentTestName(); - // All metadata fields are present only if applicable for particular metric. class MetricMetadataKey { public: