admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Autoroller: don't run presubmit hooks

Browse Source 
The presubmit lint checks require GN but it is not downloaded because runhooks is avoided on the autoroller bot.
The trybots in Gerrit UI should catch the same errors anyway, if they somehow happen.

Also minor cleanup of obsolete flag

No-Try: True
Bug: chromium:836566
Change-Id: I8bf03b8e155343f723c6fdda37210d9161da984c
Reviewed-on: https://webrtc-review.googlesource.com/c/103620
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24967}
This commit is contained in:
Oleh Prypin 2018-10-04 08:51:39 +02:00 committed by Commit Bot
parent 7f6417f480
commit e9b74a77b1
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools_webrtc/autoroller/roll_deps.py
View File

@ -592,7 +592,7 @@ def _UploadCL(commit_queue_mode):
- 1: Run trybots but do not submit to CQ. - 1: Run trybots but do not submit to CQ.
- 0: Skip CQ, upload only. - 0: Skip CQ, upload only.
""" """
cmd = ['git', 'cl', 'upload', '-f', '--gerrit'] cmd = ['git', 'cl', 'upload', '--force', '--bypass-hooks']
if commit_queue_mode >= 2: if commit_queue_mode >= 2:
logging.info('Sending the CL to the CQ...') logging.info('Sending the CL to the CQ...')
cmd.extend(['--use-commit-queue', '--send-mail']) cmd.extend(['--use-commit-queue', '--send-mail'])
@ -627,10 +627,6 @@ def main():
p.add_argument('-r', '--revision', p.add_argument('-r', '--revision',
help=('Chromium Git revision to roll to. Defaults to the ' help=('Chromium Git revision to roll to. Defaults to the '
'Chromium HEAD revision if omitted.')) 'Chromium HEAD revision if omitted.'))
p.add_argument('-u', '--rietveld-email',
help=('E-mail address to use for creating the CL at Rietveld'
'If omitted a previously cached one will be used or an '
'error will be thrown during upload.'))
p.add_argument('--dry-run', action='store_true', default=False, p.add_argument('--dry-run', action='store_true', default=False,
help=('Calculate changes and modify DEPS, but don\'t create ' help=('Calculate changes and modify DEPS, but don\'t create '
'any local branch, commit, upload CL or send any ' 'any local branch, commit, upload CL or send any '