From e8df48220589004f434c5aa99090d992b590290d Mon Sep 17 00:00:00 2001 From: Elad Alon Date: Wed, 26 Jun 2019 11:51:04 +0200 Subject: [PATCH] Clean-up after CL #140941 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:10720 Change-Id: Ie41083ea89be23e183eaff6ac1bdf661160b70cb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140942 Commit-Queue: Elad Alon Reviewed-by: Erik Språng Cr-Commit-Position: refs/heads/master@{#28388} --- api/video_codecs/vp8_frame_buffer_controller.h | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/api/video_codecs/vp8_frame_buffer_controller.h b/api/video_codecs/vp8_frame_buffer_controller.h index 91bb2f6110..e0d48515af 100644 --- a/api/video_codecs/vp8_frame_buffer_controller.h +++ b/api/video_codecs/vp8_frame_buffer_controller.h @@ -177,23 +177,12 @@ class Vp8FrameBufferControllerFactory { virtual ~Vp8FrameBufferControllerFactory() = default; // Clones oneself. (Avoids Vp8FrameBufferControllerFactoryFactory.) - // TODO(bugs.webrtc.org/10720): Update downstream and make pure-virtual. - virtual std::unique_ptr Clone() const { - return nullptr; - } + virtual std::unique_ptr Clone() const = 0; - // TODO(bugs.webrtc.org/10720): Update downstream and remove. - virtual std::unique_ptr Create( - const VideoCodec& codec) { - return nullptr; - } - - // TODO(bugs.webrtc.org/10720): Update downstream and make pure-virtual. + // Create a Vp8FrameBufferController instance. virtual std::unique_ptr Create( const VideoCodec& codec, - const VideoEncoder::Settings& settings) { - return nullptr; - } + const VideoEncoder::Settings& settings) = 0; }; } // namespace webrtc