From e79f85c10e98f3a43570d8017321842aaf4165bf Mon Sep 17 00:00:00 2001 From: Harald Alvestrand Date: Mon, 7 Feb 2022 08:39:52 +0000 Subject: [PATCH] Mark webrtc_sdp as visible target It is being used, among others, by Chrome. Bug: webrtc:13634 Change-Id: I61954e3a149ead7abf47efe67d6fbecd63ad8d2a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250961 Reviewed-by: Mirko Bonadei Commit-Queue: Harald Alvestrand Cr-Commit-Position: refs/heads/main@{#35928} --- pc/BUILD.gn | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/pc/BUILD.gn b/pc/BUILD.gn index acf5f0a376..7716e5977e 100644 --- a/pc/BUILD.gn +++ b/pc/BUILD.gn @@ -177,6 +177,8 @@ rtc_library("rtc_pc_base") { rtc_source_set("session_description") { visibility = [ "*" ] + + # TODO(bugs.webrtc.org/13661): Reduce visibility if possible sources = [ "session_description.cc", "session_description.h", @@ -201,6 +203,8 @@ rtc_source_set("session_description") { rtc_source_set("simulcast_description") { visibility = [ "*" ] + + # TODO(bugs.webrtc.org/13661): Reduce visibility if possible sources = [ "simulcast_description.cc", "simulcast_description.h", @@ -422,6 +426,8 @@ rtc_library("sctp_data_channel") { rtc_library("data_channel_utils") { visibility = [ "*" ] # Known to be used externally + + # TODO(bugs.webrtc.org/13661): Reduce visibility if possible sources = [ "data_channel_utils.cc", "data_channel_utils.h", @@ -469,6 +475,7 @@ rtc_source_set("data_channel_controller") { } rtc_source_set("peer_connection_factory") { visibility = [ "*" ] # Known to be used externally + # TODO(bugs.webrtc.org/13661): Reduce visibility if possible } rtc_source_set("peer_connection_internal") { visibility = [ ":*" ] @@ -580,7 +587,8 @@ rtc_source_set("track_media_info_map") { absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ] } rtc_source_set("webrtc_sdp") { - visibility = [ ":*" ] + visibility = [ "*" ] # Used by Chrome and more + # TODO(bugs.webrtc.org/13661): Reduce visibility if possible } rtc_source_set("webrtc_session_description_factory") { visibility = [ ":*" ] @@ -613,6 +621,8 @@ rtc_source_set("webrtc_session_description_factory") { rtc_library("ice_server_parsing") { visibility = [ "*" ] # Known to be used externally + + # TODO(bugs.webrtc.org/13661): Reduce visibility if possible sources = [ "ice_server_parsing.cc", "ice_server_parsing.h", @@ -1099,6 +1109,8 @@ rtc_source_set("stats_collector_interface") { rtc_source_set("libjingle_peerconnection") { visibility = [ "*" ] + + # TODO(bugs.webrtc.org/13661): Reduce visibility if possible deps = [ ":peerconnection", "../api:libjingle_peerconnection_api",