admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reland "Re-enable absl FailureSignalHandler in tests."

Browse Source 
This is a reland of 46e9629dda1de4315b5106741cc7072b4e01548c.

Relanding this one since it looks unrelated from the death tests
failure, see https://bugs.chromium.org/p/webrtc/issues/detail?id=11577.

Original change's description:
> Re-enable absl FailureSignalHandler in tests.
>
> It was not the cause of the SIGSEGV on iossim, so it is fine to
> re-enable it.
>
> TBR: titovartem@webrtc.org
> Bug: None
> Change-Id: I593a010f83f1a0df6b3419dd4f925380210844c9
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175105
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Artem Titov <titovartem@webrtc.org>
> Reviewed-by: Markus Handell <handellm@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31277}

TBR: titovartem@webrtc.org
Bug: None
Change-Id: I8d57c102e175bf66819f58057dd961830c2ab094
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175345
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31288}
This commit is contained in:
Mirko Bonadei 2020-05-15 15:01:54 +02:00 committed by Commit Bot
parent fd5ae7f959
commit e6e7f6a473
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/test_main.cc
View File

@ -16,11 +16,10 @@
int main(int argc, char* argv[]) { int main(int argc, char* argv[]) {
// Initialize the symbolizer to get a human-readable stack trace // Initialize the symbolizer to get a human-readable stack trace
// TODO(crbug.com/1050976): Breaks iossim tests, re-enable when fixed. absl::InitializeSymbolizer(argv[0]);
// absl::InitializeSymbolizer(argv[0]);
// absl::FailureSignalHandlerOptions options; absl::FailureSignalHandlerOptions options;
// absl::InstallFailureSignalHandler(options); absl::InstallFailureSignalHandler(options);
std::unique_ptr<webrtc::TestMain> main = webrtc::TestMain::Create(); std::unique_ptr<webrtc::TestMain> main = webrtc::TestMain::Create();
int err_code = main->Init(&argc, argv); int err_code = main->Init(&argc, argv);