From e6aa6a874093c40ef423ac06c66424a73f3aee1e Mon Sep 17 00:00:00 2001 From: Christoffer Jansson Date: Wed, 9 Feb 2022 09:17:58 +0100 Subject: [PATCH] Set file mode in the argparse argument Bug: webrtc:13607 Change-Id: I7943761933e0e110ff16b65284d8b36644b5c4ea Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251381 Reviewed-by: Mirko Bonadei Commit-Queue: Christoffer Jansson Cr-Commit-Position: refs/heads/main@{#35970} --- tools_webrtc/perf/catapult_uploader.py | 2 +- tools_webrtc/perf/webrtc_dashboard_upload.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools_webrtc/perf/catapult_uploader.py b/tools_webrtc/perf/catapult_uploader.py index 13e3ac4fcd..6dc03b85f5 100644 --- a/tools_webrtc/perf/catapult_uploader.py +++ b/tools_webrtc/perf/catapult_uploader.py @@ -195,7 +195,7 @@ def _ApplyHacks(dicts): def _LoadHistogramSetFromProto(options): hs = histogram_set.HistogramSet() - with open(options.input_results_file, 'rb') as f: + with options.input_results_file as f: hs.ImportProto(f.read()) return hs diff --git a/tools_webrtc/perf/webrtc_dashboard_upload.py b/tools_webrtc/perf/webrtc_dashboard_upload.py index 91101cad52..995d201ca8 100644 --- a/tools_webrtc/perf/webrtc_dashboard_upload.py +++ b/tools_webrtc/perf/webrtc_dashboard_upload.py @@ -58,7 +58,7 @@ def _CreateParser(): required=True, help='Which dashboard to use.') parser.add_argument('--input-results-file', - type=argparse.FileType(), + type=argparse.FileType('rb'), required=True, help='A HistogramSet proto file with output from ' 'WebRTC tests.')